From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79005-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 769 invoked by alias); 2 Mar 2011 18:32:32 -0000
Received: (qmail 761 invoked by uid 22791); 2 Mar 2011 18:32:32 -0000
X-SWARE-Spam-Status: No, hits=-5.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,TW_XT,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Mar 2011 18:32:28 +0000
Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167])	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id CEA3C17003;	Wed,  2 Mar 2011 10:32:26 -0800 (PST)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost2.vmware.com (Postfix) with ESMTP id C5A908EF19;	Wed,  2 Mar 2011 10:32:26 -0800 (PST)
Message-ID: <4D6E8D3A.405@vmware.com>
Date: Wed, 02 Mar 2011 18:32:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20101201)
MIME-Version: 1.0
To: Tom Tromey <tromey@redhat.com>
CC: Ulrich Weigand <uweigand@de.ibm.com>, Yao Qi <yao@codesourcery.com>,  "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: Fix magic number in arm-tdep.c
References: <201103021412.p22EC5vZ015623@d06av02.portsmouth.uk.ibm.com>	<4D6E88BC.9080905@vmware.com> <m3bp1t2x5m.fsf@fleche.redhat.com>
In-Reply-To: <m3bp1t2x5m.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00118.txt.bz2

Tom Tromey wrote:
>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
> 
>>>> -		nextpc = (rn == 15) ? pc_val + 8
>>>> +		nextpc = (rn == ARM_PC_REGNUM) ? pc_val + 8
>>>> : get_frame_register_unsigned (frame, rn);
>>> (? and : should remain in the same column).
>>>
> 
> Michael> I don't agree - : is an operator and should be indented by just
> Michael> two spaces.  As emacs does by default.
> 
> You're supposed to add extra parens to make it line up.
> See the "Formatting" node in the GNU Standards.
> 
> Tom

OK, that would suit me.  ;-)