From: Yao Qi <yao@codesourcery.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [commit] objc-lang.c, classes_info, avoid string overrun
Date: Tue, 01 Mar 2011 03:30:00 -0000 [thread overview]
Message-ID: <4D6C6856.8080501@codesourcery.com> (raw)
In-Reply-To: <4D6C4FDB.1030201@vmware.com>
On 03/01/2011 09:46 AM, Michael Snyder wrote:
> - if (sizeof (myregexp) < strlen (regexp) + 1)
> + if (sizeof (myregexp) < strlen (regexp) + 4)
> error (_("Regexp is too long: %s"), regexp);
> strcpy(myregexp, regexp);
It is a little bit confusing when people read this code. We may need a
short comment here.
--
Yao (é½å°§)
next prev parent reply other threads:[~2011-03-01 3:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 1:46 Michael Snyder
2011-03-01 3:30 ` Yao Qi [this message]
2011-03-01 18:51 ` Michael Snyder
2011-03-01 14:31 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6C6856.8080501@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox