From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31738 invoked by alias); 1 Mar 2011 03:30:47 -0000 Received: (qmail 31730 invoked by uid 22791); 1 Mar 2011 03:30:47 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 03:30:36 +0000 Received: (qmail 19335 invoked from network); 1 Mar 2011 03:30:33 -0000 Received: from unknown (HELO ?192.168.0.101?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Mar 2011 03:30:33 -0000 Message-ID: <4D6C6856.8080501@codesourcery.com> Date: Tue, 01 Mar 2011 03:30:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: Michael Snyder CC: "gdb-patches@sourceware.org" Subject: Re: [commit] objc-lang.c, classes_info, avoid string overrun References: <4D6C4FDB.1030201@vmware.com> In-Reply-To: <4D6C4FDB.1030201@vmware.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00014.txt.bz2 On 03/01/2011 09:46 AM, Michael Snyder wrote: > - if (sizeof (myregexp) < strlen (regexp) + 1) > + if (sizeof (myregexp) < strlen (regexp) + 4) > error (_("Regexp is too long: %s"), regexp); > strcpy(myregexp, regexp); It is a little bit confusing when people read this code. We may need a short comment here. -- Yao (齐尧)