From: Keith Seitz <keiths@redhat.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix for testsuite errors with gdbserver (remote)
Date: Fri, 18 Feb 2011 18:56:00 -0000 [thread overview]
Message-ID: <4D5EBF32.30802@redhat.com> (raw)
In-Reply-To: <000901cbcf8b$a7e35b50$f7aa11f0$@muller@ics-cnrs.unistra.fr>
On 02/18/2011 08:48 AM, Pierre Muller wrote:
> Inverting two lines in remote_close fixes hopefully this issue.
> At least using --target_board=native_gdbsderver.exp
> works again!
Duh. I didn't even notice the subsequent call to reset inferior_ptid!
I definitely like your patch better than the workaround I posted.
Although I do wonder if there are any reasons why we might want to reset
inferior_ptid after discard_all_inferiors (notifications?). Nonetheless,
I'm the pragmatic sort: if the test suite doesn't reveal such problems,
then none exist -- or we'll deal with them when we have hard test cases. :-)
Alas, I am not an ordained maintainer, so someone will still need to
officially approve this.
Thank you for following-up on this.
Keith
next prev parent reply other threads:[~2011-02-18 18:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D5C71F6.80208@vmware.com>
[not found] ` <4D5C7552.4010708@vmware.com>
[not found] ` <4D5C8312.4030701@vmware.com>
[not found] ` <4D5D6D83.8030302@vmware.com>
[not found] ` <4D5D8974.5030205@redhat.com>
2011-02-18 16:50 ` Pierre Muller
2011-02-18 18:56 ` Keith Seitz [this message]
2011-02-18 20:26 ` Pedro Alves
2011-02-18 20:30 ` Tom Tromey
2011-02-18 20:31 ` Tom Tromey
2011-02-21 11:50 ` Pedro Alves
2011-02-21 15:47 ` Pierre Muller
2011-02-21 15:54 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5EBF32.30802@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox