From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4373 invoked by alias); 18 Feb 2011 18:49:35 -0000 Received: (qmail 4364 invoked by uid 22791); 18 Feb 2011 18:49:34 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Feb 2011 18:49:30 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1IInPjO019177 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 18 Feb 2011 13:49:25 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p1IInM2S025613 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 18 Feb 2011 13:49:24 -0500 Message-ID: <4D5EBF32.30802@redhat.com> Date: Fri, 18 Feb 2011 18:56:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc13 Lightning/1.0b3pre Thunderbird/3.1.7 MIME-Version: 1.0 To: Pierre Muller CC: gdb-patches@sourceware.org Subject: Re: [RFA] Fix for testsuite errors with gdbserver (remote) References: <4D5C71F6.80208@vmware.com> <4D5C7552.4010708@vmware.com> <4D5C8312.4030701@vmware.com> <4D5D6D83.8030302@vmware.com> <4D5D8974.5030205@redhat.com> <000901cbcf8b$a7e35b50$f7aa11f0$@muller@ics-cnrs.unistra.fr> In-Reply-To: <000901cbcf8b$a7e35b50$f7aa11f0$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00491.txt.bz2 On 02/18/2011 08:48 AM, Pierre Muller wrote: > Inverting two lines in remote_close fixes hopefully this issue. > At least using --target_board=native_gdbsderver.exp > works again! Duh. I didn't even notice the subsequent call to reset inferior_ptid! I definitely like your patch better than the workaround I posted. Although I do wonder if there are any reasons why we might want to reset inferior_ptid after discard_all_inferiors (notifications?). Nonetheless, I'm the pragmatic sort: if the test suite doesn't reveal such problems, then none exist -- or we'll deal with them when we have hard test cases. :-) Alas, I am not an ordained maintainer, so someone will still need to officially approve this. Thank you for following-up on this. Keith