Re: [patch] FreeBSD powerpc (32-bit) support

[Michael Snyder <msnyder@vmware.com>]

Andreas Tobler wrote:
> Hi all,
> 
> the attached patch adds support for FreeBSD PowerPC, 32-bit.
> It is derived from ppcobsd* with FreeBSD additions.
> 
> Currently missing/incomplete:
> - Altivec support, I need to implement the necessary kernel bits first.
> - HW watchpoints, also kernel bits are missing.
> - full thread support.
> - some sig tests.
> 
> The test suite run from yesterday gave the below summary:
> 
>                  === gdb Summary ===
> 
> # of expected passes            14148
> # of unexpected failures        371
> # of expected failures          67
> # of untested testcases         34
> # of unsupported tests          87
> 
> As of today I'm not able to build with python support. Need to figure 
> out why. I guess the latest configure(.ac) does not like my output.
> (-L/usr/local/lib/python2.6/config -lutil -lm -lpython2.6 
> -Wl,--export-dynamic)
> 
> No, I do not have a gdb assignment yet. Tom already sent me the form and 
> I'll complete it soon.
> 
> 
> I'd appreciate comments and corrections.
> 
> TIA,
> Andreas
> 
> Below the ChangeLog:
> 
> 2011-01-31  Andreas Tobler  <andreast@fgznet.ch>
> 
> 	* Makefile.in (ALL_TARGET_OBS): Add powerpc FreeBSD files.
> 	* configure.host: Add powerpc-*-freebsd* target.
> 	* configure.tgt: Add target info for powerpc-*-freebsd*.
> 	* ppcfbsd-nat.c, ppcfbsd-tdep.h, ppcfbsd-tdep.c: New files.
> 	* config/powerpc/fbsd.mh: New file.

Looks nice at a first glance.

Nit: mis-indented here:


+  ppc_supply_gregset (&ppcfbsd_gregset, regcache, regno,
+			  &regs, sizeof regs);