From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-77930-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31966 invoked by alias); 31 Jan 2011 20:55:22 -0000
Received: (qmail 31957 invoked by uid 22791); 31 Jan 2011 20:55:20 -0000
X-SWARE-Spam-Status: No, hits=-4.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Jan 2011 20:55:16 +0000
Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167])	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id D413A57006;	Mon, 31 Jan 2011 12:55:14 -0800 (PST)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost2.vmware.com (Postfix) with ESMTP id CAA798EF9C;	Mon, 31 Jan 2011 12:55:14 -0800 (PST)
Message-ID: <4D4721B2.3080606@vmware.com>
Date: Mon, 31 Jan 2011 21:38:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20101201)
MIME-Version: 1.0
To: Andreas Tobler <andreast-list@fgznet.ch>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] FreeBSD powerpc (32-bit) support
References: <4D471E05.9090307@fgznet.ch>
In-Reply-To: <4D471E05.9090307@fgznet.ch>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-01/txt/msg00598.txt.bz2

Andreas Tobler wrote:
> Hi all,
> 
> the attached patch adds support for FreeBSD PowerPC, 32-bit.
> It is derived from ppcobsd* with FreeBSD additions.
> 
> Currently missing/incomplete:
> - Altivec support, I need to implement the necessary kernel bits first.
> - HW watchpoints, also kernel bits are missing.
> - full thread support.
> - some sig tests.
> 
> The test suite run from yesterday gave the below summary:
> 
>                  === gdb Summary ===
> 
> # of expected passes            14148
> # of unexpected failures        371
> # of expected failures          67
> # of untested testcases         34
> # of unsupported tests          87
> 
> As of today I'm not able to build with python support. Need to figure 
> out why. I guess the latest configure(.ac) does not like my output.
> (-L/usr/local/lib/python2.6/config -lutil -lm -lpython2.6 
> -Wl,--export-dynamic)
> 
> No, I do not have a gdb assignment yet. Tom already sent me the form and 
> I'll complete it soon.
> 
> 
> I'd appreciate comments and corrections.
> 
> TIA,
> Andreas
> 
> Below the ChangeLog:
> 
> 2011-01-31  Andreas Tobler  <andreast@fgznet.ch>
> 
> 	* Makefile.in (ALL_TARGET_OBS): Add powerpc FreeBSD files.
> 	* configure.host: Add powerpc-*-freebsd* target.
> 	* configure.tgt: Add target info for powerpc-*-freebsd*.
> 	* ppcfbsd-nat.c, ppcfbsd-tdep.h, ppcfbsd-tdep.c: New files.
> 	* config/powerpc/fbsd.mh: New file.

Looks nice at a first glance.

Nit: mis-indented here:


+  ppc_supply_gregset (&ppcfbsd_gregset, regcache, regno,
+			  &regs, sizeof regs);