From: Michael Snyder <msnyder@vmware.com>
To: David Daney <ddaney@caviumnetworks.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: Ping: [Patch v2] Add mips*-linux* catch syscall support.
Date: Mon, 31 Jan 2011 19:52:00 -0000 [thread overview]
Message-ID: <4D47116A.7080001@vmware.com> (raw)
In-Reply-To: <4D46F658.3020302@caviumnetworks.com>
David Daney wrote:
> If it is not too much trouble, could a Maintainer review this patch?
>
> Thanks in advance,
> David Daney
There's an off-by-one indentation here:
+static LONGEST
+mips_linux_get_syscall_number (struct gdbarch *gdbarch,
+ ptid_t ptid)
Other than that, the part in mips-linux-tdep.c looks reasonable.
I don't understand the xml parts well enough to comment.
next prev parent reply other threads:[~2011-01-31 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 20:20 David Daney
2011-01-31 19:00 ` Ping: " David Daney
2011-01-31 19:52 ` Michael Snyder [this message]
2011-01-31 20:08 ` David Daney
2011-02-04 16:11 ` Tom Tromey
2011-02-04 16:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D47116A.7080001@vmware.com \
--to=msnyder@vmware.com \
--cc=ddaney@caviumnetworks.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox