From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10176 invoked by alias); 31 Jan 2011 19:45:53 -0000 Received: (qmail 10164 invoked by uid 22791); 31 Jan 2011 19:45:52 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Jan 2011 19:45:48 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 08E421305C; Mon, 31 Jan 2011 11:45:47 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost2.vmware.com (Postfix) with ESMTP id F056D8EC5C; Mon, 31 Jan 2011 11:45:46 -0800 (PST) Message-ID: <4D47116A.7080001@vmware.com> Date: Mon, 31 Jan 2011 19:52:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: David Daney CC: "gdb-patches@sourceware.org" Subject: Re: Ping: [Patch v2] Add mips*-linux* catch syscall support. References: <4D3DD73C.9060201@caviumnetworks.com> <4D46F658.3020302@caviumnetworks.com> In-Reply-To: <4D46F658.3020302@caviumnetworks.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00593.txt.bz2 David Daney wrote: > If it is not too much trouble, could a Maintainer review this patch? > > Thanks in advance, > David Daney There's an off-by-one indentation here: +static LONGEST +mips_linux_get_syscall_number (struct gdbarch *gdbarch, + ptid_t ptid) Other than that, the part in mips-linux-tdep.c looks reasonable. I don't understand the xml parts well enough to comment.