From: Yao Qi <yao@codesourcery.com>
To: Ken Werner <ken@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Changes to the OpenCL testsuite
Date: Mon, 24 Jan 2011 22:04:00 -0000 [thread overview]
Message-ID: <4D3DF610.2070905@codesourcery.com> (raw)
In-Reply-To: <201101242136.29609.ken@linux.vnet.ibm.com>
On 01/25/2011 04:36 AM, Ken Werner wrote:
> 2011-01-24 Ken Werner <ken.werner@de.ibm.com>
>
> * gdb.opencl/convs_casts.cl: Move program scope variables into the
> OpenCL kernel function. Add a comment as marker.
> * gdb.opencl/datatypes.cl: Likewise.
> * gdb.opencl/operators.cl: Likewise.
> * gdb.opencl/vec_comps.cl: Likewise.
> * gdb.opencl/convs_casts.exp: Replace gdb_test_multiple by gdb_test.
> Add breakpoint at the marker comment.
> * gdb.opencl/datatypes.exp: Likewise.
> * gdb.opencl/operators.exp: Likewise.
> * gdb.opencl/vec_comps.exp: Likewise.
>
I am not the people to approve this patch. Some of my cents below,
> Index: gdb/testsuite/gdb.opencl/convs_casts.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.opencl/convs_casts.exp,v
> retrieving revision 1.2
> diff -p -u -r1.2 convs_casts.exp
> --- gdb/testsuite/gdb.opencl/convs_casts.exp 1 Jan 2011 15:33:48 -0000 1.2
> +++ gdb/testsuite/gdb.opencl/convs_casts.exp 24 Jan 2011 19:55:01 -0000
> @@ -1,4 +1,4 @@
> -# Copyright 2010, 2011 Free Software Foundation, Inc.
> +# Copyright 2010 Free Software Foundation, Inc.
Any reason to remove "2011" here? At least, this change is not
reflected in ChangeLog entry. Presumably, it is changed by mistake, if
so, we should remove this chunk from patch.
> -__kernel void testkernel (__global int *data)
> -{
> + /* marker! */
Generally, we leave either period/two-spaces or single space at the end
of comment. In your case, we can use single space since your comment is
short.
--
Yao (é½å°§)
next prev parent reply other threads:[~2011-01-24 21:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 20:54 Ken Werner
2011-01-24 22:04 ` Yao Qi [this message]
2011-01-25 8:46 ` Ken Werner
2011-01-25 14:22 ` Ulrich Weigand
2011-01-25 16:26 ` Ken Werner
2011-01-31 19:45 ` [commit] Fix test suite race (Re: [patch] Changes to the OpenCL testsuite) Ulrich Weigand
2011-01-25 15:22 ` [patch] Changes to the OpenCL testsuite Yao Qi
2011-01-25 16:16 ` Ken Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3DF610.2070905@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=ken@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox