From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30214 invoked by alias); 24 Jan 2011 21:58:56 -0000 Received: (qmail 30169 invoked by uid 22791); 24 Jan 2011 21:58:56 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Jan 2011 21:58:51 +0000 Received: (qmail 25270 invoked from network); 24 Jan 2011 21:58:46 -0000 Received: from unknown (HELO ?192.168.0.101?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 24 Jan 2011 21:58:46 -0000 Message-ID: <4D3DF610.2070905@codesourcery.com> Date: Mon, 24 Jan 2011 22:04:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 MIME-Version: 1.0 To: Ken Werner CC: gdb-patches@sourceware.org Subject: Re: [patch] Changes to the OpenCL testsuite References: <201101242136.29609.ken@linux.vnet.ibm.com> In-Reply-To: <201101242136.29609.ken@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00476.txt.bz2 On 01/25/2011 04:36 AM, Ken Werner wrote: > 2011-01-24 Ken Werner > > * gdb.opencl/convs_casts.cl: Move program scope variables into the > OpenCL kernel function. Add a comment as marker. > * gdb.opencl/datatypes.cl: Likewise. > * gdb.opencl/operators.cl: Likewise. > * gdb.opencl/vec_comps.cl: Likewise. > * gdb.opencl/convs_casts.exp: Replace gdb_test_multiple by gdb_test. > Add breakpoint at the marker comment. > * gdb.opencl/datatypes.exp: Likewise. > * gdb.opencl/operators.exp: Likewise. > * gdb.opencl/vec_comps.exp: Likewise. > I am not the people to approve this patch. Some of my cents below, > Index: gdb/testsuite/gdb.opencl/convs_casts.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.opencl/convs_casts.exp,v > retrieving revision 1.2 > diff -p -u -r1.2 convs_casts.exp > --- gdb/testsuite/gdb.opencl/convs_casts.exp 1 Jan 2011 15:33:48 -0000 1.2 > +++ gdb/testsuite/gdb.opencl/convs_casts.exp 24 Jan 2011 19:55:01 -0000 > @@ -1,4 +1,4 @@ > -# Copyright 2010, 2011 Free Software Foundation, Inc. > +# Copyright 2010 Free Software Foundation, Inc. Any reason to remove "2011" here? At least, this change is not reflected in ChangeLog entry. Presumably, it is changed by mistake, if so, we should remove this chunk from patch. > -__kernel void testkernel (__global int *data) > -{ > + /* marker! */ Generally, we leave either period/two-spaces or single space at the end of comment. In your case, we can use single space since your comment is short. -- Yao (齐尧)