From: "Philippe Waroquiers" <philippe.waroquiers@skynet.be>
To: "Eli Zaretskii" <eliz@gnu.org>
Cc: <gdb-patches@sourceware.org>
Subject: Re: PATCH : allow to set length of hw watchpoints (e.g. for Valgrind gdbserver)
Date: Sun, 15 May 2011 20:43:00 -0000 [thread overview]
Message-ID: <4D2C2F3FEA7B42649388528CB2CDC39B@soleil> (raw)
In-Reply-To: <83sjsfemfz.fsf@gnu.org>
>> Note that I have kept 'int' as all other similar variables are int, and an int
>> will be large enough for any reasonable watchpoint.
>
> I'm not convinced, but I'll let others speak up.
I was also (initially) convinced to go for ssize_t.
But the reason given above + the fact that I could not find the equivalent
of add_setshow_zinteger_cmd for an ssize_t made me believe an int was
good enough.
For sure, if such an equivalent exists, it will be trivial to change to ssize_t.
Without such an equivalent, there will be some more work
to define e.g. add_setshow_zssize_t_cmd.
> These are fine, but please leave 2 spaces between sentences in the
> NEWS entry.
I assume there will be some other comments (maybe related to ssize_t).
I will update NEWS together with handling the other comments.
Thanks again for the review.
Philippe
prev parent reply other threads:[~2011-05-15 20:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-15 17:39 Philippe Waroquiers
2011-05-15 17:47 ` Eli Zaretskii
2011-05-15 20:12 ` Philippe Waroquiers
2011-05-15 20:30 ` Eli Zaretskii
2011-05-15 20:43 ` Philippe Waroquiers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2C2F3FEA7B42649388528CB2CDC39B@soleil \
--to=philippe.waroquiers@skynet.be \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox