From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21674 invoked by alias); 15 May 2011 20:43:48 -0000 Received: (qmail 21666 invoked by uid 22791); 15 May 2011 20:43:48 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mailrelay006.isp.belgacom.be (HELO mailrelay006.isp.belgacom.be) (195.238.6.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 15 May 2011 20:43:33 +0000 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ag0FAMc40E1tgDRo/2dsb2JhbACKJ5tseIhpB71fDoYLBJ8I Received: from 104.52-128-109.adsl-dyn.isp.belgacom.be (HELO soleil) ([109.128.52.104]) by relay.skynet.be with SMTP; 15 May 2011 22:43:31 +0200 Message-ID: <4D2C2F3FEA7B42649388528CB2CDC39B@soleil> From: "Philippe Waroquiers" To: "Eli Zaretskii" Cc: References: <83vcxbeu07.fsf@gnu.org> <6CA956FB8BFB4CAB823CD8593BA606B0@soleil> <83sjsfemfz.fsf@gnu.org> Subject: Re: PATCH : allow to set length of hw watchpoints (e.g. for Valgrind gdbserver) Date: Sun, 15 May 2011 20:43:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00352.txt.bz2 >> Note that I have kept 'int' as all other similar variables are int, and an int >> will be large enough for any reasonable watchpoint. > > I'm not convinced, but I'll let others speak up. I was also (initially) convinced to go for ssize_t. But the reason given above + the fact that I could not find the equivalent of add_setshow_zinteger_cmd for an ssize_t made me believe an int was good enough. For sure, if such an equivalent exists, it will be trivial to change to ssize_t. Without such an equivalent, there will be some more work to define e.g. add_setshow_zssize_t_cmd. > These are fine, but please leave 2 spaces between sentences in the > NEWS entry. I assume there will be some other comments (maybe related to ssize_t). I will update NEWS together with handling the other comments. Thanks again for the review. Philippe