From: Michael Snyder <msnyder@vmware.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] comment cleanup
Date: Wed, 29 Dec 2010 22:30:00 -0000 [thread overview]
Message-ID: <4D1B8C36.4070006@vmware.com> (raw)
In-Reply-To: <20101229102103.GA7592@adacore.com>
Joel Brobecker wrote:
>> 2010-12-28 Michael Snyder <msnyder@vmware.com>
>>
>> * event-loop.c: Comment clean-up.
>> * event-loop.h: Ditto.
>> * event-top.c: Ditto.
>> * gdb.c: Ditto.
>> * gdb.h: Ditto.
>> * main.c: Ditto.
>> * top.c: Ditto.
>> * top.h: Ditto.
>
> I just noticed that gdb.c contains unadvertized code updates :-),
> and this is causing the build to fail on platforms where mcheck.h
> is not available (Eg. ppc-aix).
>
> These have now been reverted with the following commit.
Ouch, sorry about that. Thanks for catching it.
I had been using mtrace to look for memory leaks, and forgot to take it out.
>
>> Index: gdb.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/gdb.c,v
>> retrieving revision 1.9
>> diff -u -p -r1.9 gdb.c
>> --- gdb.c 14 May 2010 20:17:37 -0000 1.9
>> +++ gdb.c 29 Dec 2010 00:53:53 -0000
>> @@ -20,16 +20,21 @@
>> #include "main.h"
>> #include "gdb_string.h"
>> #include "interps.h"
>> +#include <mcheck.h>
>>
>> int
>> main (int argc, char **argv)
>> {
>> struct captured_main_args args;
>> + int ret;
>>
>> + mtrace ();
>> memset (&args, 0, sizeof args);
>> args.argc = argc;
>> args.argv = argv;
>> args.use_windows = 0;
>> args.interpreter_p = INTERP_CONSOLE;
>> - return gdb_main (&args);
>> + ret = gdb_main (&args);
>> + muntrace();
>> + return ret;
>
prev parent reply other threads:[~2010-12-29 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 1:57 Michael Snyder
2010-12-29 11:16 ` Joel Brobecker
2010-12-29 22:30 ` Michael Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D1B8C36.4070006@vmware.com \
--to=msnyder@vmware.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox