From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15191 invoked by alias); 29 Dec 2010 19:30:08 -0000 Received: (qmail 15181 invoked by uid 22791); 29 Dec 2010 19:30:07 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Dec 2010 19:30:00 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 2784449002; Wed, 29 Dec 2010 11:29:59 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 15563CD94B; Wed, 29 Dec 2010 11:29:59 -0800 (PST) Message-ID: <4D1B8C36.4070006@vmware.com> Date: Wed, 29 Dec 2010 22:30:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Joel Brobecker CC: "gdb-patches@sourceware.org" Subject: Re: [patch] comment cleanup References: <4D1A8801.8050802@vmware.com> <20101229102103.GA7592@adacore.com> In-Reply-To: <20101229102103.GA7592@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00551.txt.bz2 Joel Brobecker wrote: >> 2010-12-28 Michael Snyder >> >> * event-loop.c: Comment clean-up. >> * event-loop.h: Ditto. >> * event-top.c: Ditto. >> * gdb.c: Ditto. >> * gdb.h: Ditto. >> * main.c: Ditto. >> * top.c: Ditto. >> * top.h: Ditto. > > I just noticed that gdb.c contains unadvertized code updates :-), > and this is causing the build to fail on platforms where mcheck.h > is not available (Eg. ppc-aix). > > These have now been reverted with the following commit. Ouch, sorry about that. Thanks for catching it. I had been using mtrace to look for memory leaks, and forgot to take it out. > >> Index: gdb.c >> =================================================================== >> RCS file: /cvs/src/src/gdb/gdb.c,v >> retrieving revision 1.9 >> diff -u -p -r1.9 gdb.c >> --- gdb.c 14 May 2010 20:17:37 -0000 1.9 >> +++ gdb.c 29 Dec 2010 00:53:53 -0000 >> @@ -20,16 +20,21 @@ >> #include "main.h" >> #include "gdb_string.h" >> #include "interps.h" >> +#include >> >> int >> main (int argc, char **argv) >> { >> struct captured_main_args args; >> + int ret; >> >> + mtrace (); >> memset (&args, 0, sizeof args); >> args.argc = argc; >> args.argv = argv; >> args.use_windows = 0; >> args.interpreter_p = INTERP_CONSOLE; >> - return gdb_main (&args); >> + ret = gdb_main (&args); >> + muntrace(); >> + return ret; >