From: Michael Snyder <msnyder@vmware.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Hui Zhu <teawater@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA/RFC] tracepoint gdbrsp: add -1 introduce for QTFrame:@var{n}
Date: Sun, 15 Aug 2010 19:05:00 -0000 [thread overview]
Message-ID: <4C683A6C.8040501@vmware.com> (raw)
In-Reply-To: <201008151946.55330.pedro@codesourcery.com>
Pedro Alves wrote:
> On Sunday 15 August 2010 08:16:34, Hui Zhu wrote:
>> Sending packet: $QTFrame:ffffffff#fa...Packet received: OK
>
> I think it is a bug that this is assuming 32-bit, two's complement
> on both client/server sides. (not sure it that was what you were
> referring to).
It's not really assuming that -- it's just assuming that no
legitimate frame ID will ever be as high as ffffffff.
That might also be iffy, but less so....
IMO, negatives should have an explicit '-' encoding; in
> this case, "$QTFrame:-1". Note sure if the RSP docs mention something
> about this. We are careful in some cases (passing thread id's,
> I think, is one case), though clearly not everywhere.
>
next prev parent reply other threads:[~2010-08-15 19:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-15 7:17 Hui Zhu
2010-08-15 17:20 ` Michael Snyder
2010-08-15 18:07 ` Eli Zaretskii
2010-08-15 18:14 ` Pedro Alves
2010-08-15 18:47 ` Pedro Alves
2010-08-15 19:05 ` Michael Snyder [this message]
2010-08-15 23:10 ` Pedro Alves
2010-08-19 7:44 ` Hui Zhu
2010-08-19 7:49 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C683A6C.8040501@vmware.com \
--to=msnyder@vmware.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox