From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7718 invoked by alias); 15 Aug 2010 19:05:23 -0000 Received: (qmail 7710 invoked by uid 22791); 15 Aug 2010 19:05:22 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 15 Aug 2010 19:05:18 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id E590C38005; Sun, 15 Aug 2010 12:05:16 -0700 (PDT) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id DB2FDCD957; Sun, 15 Aug 2010 12:05:16 -0700 (PDT) Message-ID: <4C683A6C.8040501@vmware.com> Date: Sun, 15 Aug 2010 19:05:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.22 (X11/20090609) MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" , Hui Zhu , Eli Zaretskii Subject: Re: [RFA/RFC] tracepoint gdbrsp: add -1 introduce for QTFrame:@var{n} References: <201008151946.55330.pedro@codesourcery.com> In-Reply-To: <201008151946.55330.pedro@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00215.txt.bz2 Pedro Alves wrote: > On Sunday 15 August 2010 08:16:34, Hui Zhu wrote: >> Sending packet: $QTFrame:ffffffff#fa...Packet received: OK > > I think it is a bug that this is assuming 32-bit, two's complement > on both client/server sides. (not sure it that was what you were > referring to). It's not really assuming that -- it's just assuming that no legitimate frame ID will ever be as high as ffffffff. That might also be iffy, but less so.... IMO, negatives should have an explicit '-' encoding; in > this case, "$QTFrame:-1". Note sure if the RSP docs mention something > about this. We are careful in some cases (passing thread id's, > I think, is one case), though clearly not everywhere. >