Re: [RFA] gdb.base -- use gdb_test_no_output

[Michael Snyder <msnyder@vmware.com>]

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]

Ulrich Weigand wrote:
> Jan Kratochvil wrote:
> 
>> FYI in the testcase the inferior is no loner running when `set language asm' is
>> entered.  There is preceding:
>>
>> (gdb) run^M
>> Starting program: .../gdb.base/setshow foo bar blup baz bubble^M
>> foo bar blup baz bubble ^M
>> Program exited normally.^M
>> (gdb) PASS: gdb.base/setshow.exp: passing args
> 
> Ah, that would explain it!  This part of setshow.exp:
> 
> # Don't test if we can't pass args or if we're using a stub.
> if { ![target_info exists use_gdb_stub] && ![target_info exists noargs] } {
>     #test passing args
>     gdb_test "cont" "Continuing.*" "continuing"
>     delete_breakpoints
>     gdb_test "run" "Starting program:.*foo bar blup baz bubble.*" "passing args"
> }
> 
> is skipped on spu-elf because we cannot pass command line arguments
> (well, at least it's not set up that way).
> 
> However, it seems to me that this is still a bug: I don't really think the
> intention was that the remaining checks are to be executed on a running
> inferior on some targets, and on a exited inferior on others ...

I'm reverting that line of change, as attached.





[-- Attachment #2: setshow.txt --]
[-- Type: text/plain, Size: 963 bytes --]

2010-06-11  Michael Snyder  <msnyder@vmware.com>

	* gdb.base/setshow.exp (set language asm): Don't use
	gdb_test_no_output, fails on some targets.

Index: gdb.base/setshow.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/setshow.exp,v
retrieving revision 1.18
diff -u -p -r1.18 setshow.exp
--- gdb.base/setshow.exp	10 Jun 2010 19:48:19 -0000	1.18
+++ gdb.base/setshow.exp	11 Jun 2010 20:55:26 -0000
@@ -173,7 +173,7 @@ gdb_test_no_output "set history size 100
 #test show history size 100
 gdb_test "show history size" "The size of the command history is 100..*" "show history size (100)" 
 #test set language asm
-gdb_test_no_output "set language asm" "set language asm" 
+gdb_test "set language asm" ".*" "set language asm" 
 #test show language asm
 gdb_test "show language" "The current source language is \"asm\"..*" "show language (asm)" 
 #test set language java, with a trailing space