From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20247 invoked by alias); 11 Jun 2010 20:57:05 -0000 Received: (qmail 20229 invoked by uid 22791); 11 Jun 2010 20:57:05 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Jun 2010 20:57:00 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 5DC2029002; Fri, 11 Jun 2010 13:56:59 -0700 (PDT) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 57CE6CD905; Fri, 11 Jun 2010 13:56:59 -0700 (PDT) Message-ID: <4C12A31B.2060500@vmware.com> Date: Fri, 11 Jun 2010 20:57:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.22 (X11/20090609) MIME-Version: 1.0 To: Ulrich Weigand CC: Jan Kratochvil , "gdb-patches@sourceware.org" Subject: Re: [RFA] gdb.base -- use gdb_test_no_output References: <201006111935.o5BJZ0cJ021385@d12av02.megacenter.de.ibm.com> In-Reply-To: <201006111935.o5BJZ0cJ021385@d12av02.megacenter.de.ibm.com> Content-Type: multipart/mixed; boundary="------------020907030006030106020801" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00289.txt.bz2 This is a multi-part message in MIME format. --------------020907030006030106020801 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1143 Ulrich Weigand wrote: > Jan Kratochvil wrote: > >> FYI in the testcase the inferior is no loner running when `set language asm' is >> entered. There is preceding: >> >> (gdb) run^M >> Starting program: .../gdb.base/setshow foo bar blup baz bubble^M >> foo bar blup baz bubble ^M >> Program exited normally.^M >> (gdb) PASS: gdb.base/setshow.exp: passing args > > Ah, that would explain it! This part of setshow.exp: > > # Don't test if we can't pass args or if we're using a stub. > if { ![target_info exists use_gdb_stub] && ![target_info exists noargs] } { > #test passing args > gdb_test "cont" "Continuing.*" "continuing" > delete_breakpoints > gdb_test "run" "Starting program:.*foo bar blup baz bubble.*" "passing args" > } > > is skipped on spu-elf because we cannot pass command line arguments > (well, at least it's not set up that way). > > However, it seems to me that this is still a bug: I don't really think the > intention was that the remaining checks are to be executed on a running > inferior on some targets, and on a exited inferior on others ... I'm reverting that line of change, as attached. --------------020907030006030106020801 Content-Type: text/plain; name="setshow.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="setshow.txt" Content-length: 963 2010-06-11 Michael Snyder * gdb.base/setshow.exp (set language asm): Don't use gdb_test_no_output, fails on some targets. Index: gdb.base/setshow.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/setshow.exp,v retrieving revision 1.18 diff -u -p -r1.18 setshow.exp --- gdb.base/setshow.exp 10 Jun 2010 19:48:19 -0000 1.18 +++ gdb.base/setshow.exp 11 Jun 2010 20:55:26 -0000 @@ -173,7 +173,7 @@ gdb_test_no_output "set history size 100 #test show history size 100 gdb_test "show history size" "The size of the command history is 100..*" "show history size (100)" #test set language asm -gdb_test_no_output "set language asm" "set language asm" +gdb_test "set language asm" ".*" "set language asm" #test show language asm gdb_test "show language" "The current source language is \"asm\"..*" "show language (asm)" #test set language java, with a trailing space --------------020907030006030106020801--