Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: DJ Delorie <dj@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: RX Sim: Use unsigned masks when setting flag bits
Date: Tue, 08 Jun 2010 09:17:00 -0000	[thread overview]
Message-ID: <4C0E0A9F.20102@redhat.com> (raw)
In-Reply-To: <201006071754.o57Hsd0C012374@greed.delorie.com>

Hi DJ,

> I wonder if the definition of b2mask[] should have "UL" on the
> 0xfffffff too ?  It seems to work already though ;-)

I actually tested making the array contain long long masks, since they 
were being used to test against long long values, but this broke the 
computation that determines the carry bit, so I abandoned that change.

> Otherwise, I think this patch is OK.

Thanks - committed.

Cheers
   Nick

sim/ChangeLog

	* reg.c (set_oszc): Use unsigned int for the mask.
	(set_szc, set_osz, set_sz): Likewise.


      reply	other threads:[~2010-06-08  9:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-07  7:50 Nick Clifton
2010-06-07 17:54 ` DJ Delorie
2010-06-08  9:17   ` Nick Clifton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C0E0A9F.20102@redhat.com \
    --to=nickc@redhat.com \
    --cc=dj@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox