From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73606-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24772 invoked by alias); 8 Jun 2010 09:17:30 -0000
Received: (qmail 24755 invoked by uid 22791); 8 Jun 2010 09:17:30 -0000
X-SWARE-Spam-Status: No, hits=-5.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_XF,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Jun 2010 09:17:22 +0000
Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o589HLTG003472	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Tue, 8 Jun 2010 05:17:21 -0400
Received: from [10.36.9.217] (vpn2-9-217.ams2.redhat.com [10.36.9.217])	by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o589HJLZ010334;	Tue, 8 Jun 2010 05:17:20 -0400
Message-ID: <4C0E0A9F.20102@redhat.com>
Date: Tue, 08 Jun 2010 09:17:00 -0000
From: Nick Clifton <nickc@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4
MIME-Version: 1.0
To: DJ Delorie <dj@redhat.com>
CC: gdb-patches@sourceware.org
Subject: Re: RFA: RX Sim: Use unsigned masks when setting flag bits
References: <m339wzqo1z.fsf@redhat.com> <201006071754.o57Hsd0C012374@greed.delorie.com>
In-Reply-To: <201006071754.o57Hsd0C012374@greed.delorie.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-06/txt/msg00199.txt.bz2

Hi DJ,

> I wonder if the definition of b2mask[] should have "UL" on the
> 0xfffffff too ?  It seems to work already though ;-)

I actually tested making the array contain long long masks, since they 
were being used to test against long long values, but this broke the 
computation that determines the carry bit, so I abandoned that change.

> Otherwise, I think this patch is OK.

Thanks - committed.

Cheers
   Nick

sim/ChangeLog

	* reg.c (set_oszc): Use unsigned int for the mask.
	(set_szc, set_osz, set_sz): Likewise.