Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] gdb.base/pending.exp replace gdb_test_multi
Date: Mon, 07 Jun 2010 23:00:00 -0000	[thread overview]
Message-ID: <4C0D79F3.4070005@vmware.com> (raw)
In-Reply-To: <20100607225102.GA8046@host0.dyn.jankratochvil.net>

Jan Kratochvil wrote:
> On Sat, 05 Jun 2010 00:16:42 +0200, Michael Snyder wrote:
>> This is a simplification.
> 
>> -gdb_test_multiple "break pendfunc2" "Don't set pending breakpoint" {
>> -     -re ".*Make breakpoint pending.*y or \\\[n\\\]. $" {
>> -	    gdb_test "n" "" "Don't set pending breakpoint"
>> -     }
>> -}
>> +gdb_test "break pendfunc2" \
>> +    "" \
>> +    "Don't set pending breakpoint" \
>> +    ".*Make breakpoint pending.*y or \\\[n\\\]. $" \
>> +    "n"
> 
> With ".*" vs. gdb_test_no_output distinguishing now should be ".*" here
> instead?  (Maybe a more specific string would be also appropriate.)


No, unfortunately, the expected string here is the empty string;
if we had said "y" to the query, then there would be some output
for us to look for.

Believe me, it's almost heart-breaking for me to have to leave this,
but I don't see it as worthwhile to extend gdb_test_no_output to
handle the query case.

Michael


  reply	other threads:[~2010-06-07 23:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-04 22:16 Michael Snyder
2010-06-07 22:51 ` Jan Kratochvil
2010-06-07 23:00   ` Michael Snyder [this message]
2010-06-08 17:34     ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C0D79F3.4070005@vmware.com \
    --to=msnyder@vmware.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox