From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73600-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29830 invoked by alias); 7 Jun 2010 23:00:09 -0000
Received: (qmail 29811 invoked by uid 22791); 7 Jun 2010 23:00:08 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Jun 2010 23:00:04 +0000
Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45])	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 79D894D003;	Mon,  7 Jun 2010 16:00:03 -0700 (PDT)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost3.vmware.com (Postfix) with ESMTP id 7180FCD926;	Mon,  7 Jun 2010 16:00:03 -0700 (PDT)
Message-ID: <4C0D79F3.4070005@vmware.com>
Date: Mon, 07 Jun 2010 23:00:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.22 (X11/20090609)
MIME-Version: 1.0
To: Jan Kratochvil <jan.kratochvil@redhat.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] gdb.base/pending.exp replace gdb_test_multi
References: <4C097B4A.8080005@vmware.com> <20100607225102.GA8046@host0.dyn.jankratochvil.net>
In-Reply-To: <20100607225102.GA8046@host0.dyn.jankratochvil.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-06/txt/msg00193.txt.bz2

Jan Kratochvil wrote:
> On Sat, 05 Jun 2010 00:16:42 +0200, Michael Snyder wrote:
>> This is a simplification.
> 
>> -gdb_test_multiple "break pendfunc2" "Don't set pending breakpoint" {
>> -     -re ".*Make breakpoint pending.*y or \\\[n\\\]. $" {
>> -	    gdb_test "n" "" "Don't set pending breakpoint"
>> -     }
>> -}
>> +gdb_test "break pendfunc2" \
>> +    "" \
>> +    "Don't set pending breakpoint" \
>> +    ".*Make breakpoint pending.*y or \\\[n\\\]. $" \
>> +    "n"
> 
> With ".*" vs. gdb_test_no_output distinguishing now should be ".*" here
> instead?  (Maybe a more specific string would be also appropriate.)


No, unfortunately, the expected string here is the empty string;
if we had said "y" to the query, then there would be some output
for us to look for.

Believe me, it's almost heart-breaking for me to have to leave this,
but I don't see it as worthwhile to extend gdb_test_no_output to
handle the query case.

Michael