Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: "tromey@redhat.com" <tromey@redhat.com>
Cc: Pedro Alves <pedro@codesourcery.com>,
	 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [ob] remote.c, eliminate unused variables
Date: Fri, 07 May 2010 18:51:00 -0000	[thread overview]
Message-ID: <4BE4612B.2080201@vmware.com> (raw)
In-Reply-To: <m31vdnhalv.fsf@fleche.redhat.com>

Tom Tromey wrote:
>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
> 
> Michael> No, I'm attempting to make the code easier to understand by
> Michael> removing dead code and variables.  Since this warning is
> Michael> turned off, I'm not even reducing the number of warnings.
> 
> Are you planning to enable them?  I hope so, since otherwise this work
> will quickly regress.

I was, but there have been a handful of cases that I could not eliminate 
so far.

> 
> FWIW I read through all the patches and sent comments about the changes
> I saw that seemed fishy.

Thanks, the review is much appreciated.


      reply	other threads:[~2010-05-07 18:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05 20:47 Michael Snyder
2010-05-05 20:51 ` Pedro Alves
2010-05-05 21:14   ` Michael Snyder
2010-05-05 21:41     ` Pedro Alves
2010-05-05 22:22       ` Michael Snyder
2010-05-05 22:39         ` Pedro Alves
2010-05-07 17:42         ` Tom Tromey
2010-05-07 18:51           ` Michael Snyder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE4612B.2080201@vmware.com \
    --to=msnyder@vmware.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox