From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72905-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32285 invoked by alias); 7 May 2010 18:51:28 -0000
Received: (qmail 32276 invoked by uid 22791); 7 May 2010 18:51:28 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 May 2010 18:51:24 +0000
Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167])	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 74627C004;	Fri,  7 May 2010 11:51:23 -0700 (PDT)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost2.vmware.com (Postfix) with ESMTP id 6AE1B8E9A1;	Fri,  7 May 2010 11:51:23 -0700 (PDT)
Message-ID: <4BE4612B.2080201@vmware.com>
Date: Fri, 07 May 2010 18:51:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.22 (X11/20090609)
MIME-Version: 1.0
To: "tromey@redhat.com" <tromey@redhat.com>
CC: Pedro Alves <pedro@codesourcery.com>,  "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [ob] remote.c, eliminate unused variables
References: <4BE1D93F.8000309@vmware.com>	<201005052151.19745.pedro@codesourcery.com>	<4BE1DFA9.9060607@vmware.com>	<201005052241.14753.pedro@codesourcery.com>	<4BE1EF9C.8070807@vmware.com> <m31vdnhalv.fsf@fleche.redhat.com>
In-Reply-To: <m31vdnhalv.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00198.txt.bz2

Tom Tromey wrote:
>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
> 
> Michael> No, I'm attempting to make the code easier to understand by
> Michael> removing dead code and variables.  Since this warning is
> Michael> turned off, I'm not even reducing the number of warnings.
> 
> Are you planning to enable them?  I hope so, since otherwise this work
> will quickly regress.

I was, but there have been a handful of cases that I could not eliminate 
so far.

> 
> FWIW I read through all the patches and sent comments about the changes
> I saw that seemed fishy.

Thanks, the review is much appreciated.