From: Michael Snyder <msnyder@vmware.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] ada-lang, c-lang, f-lang, objc-lang, jv-lang, m2-lang, ada-tasks.c: delete unused variables
Date: Fri, 07 May 2010 18:23:00 -0000 [thread overview]
Message-ID: <4BE45AA1.4080706@vmware.com> (raw)
In-Reply-To: <20100507031644.GZ2768@adacore.com>
Joel Brobecker wrote:
>> --- jv-lang.c 22 Apr 2010 23:15:41 -0000 1.83
>> +++ jv-lang.c 6 May 2010 23:35:37 -0000
>> @@ -268,8 +268,10 @@ type_from_class (struct gdbarch *gdbarch
>> struct value *utf8_name;
>> char *nptr;
>> CORE_ADDR addr;
>> +#if 0
>> struct block *bl;
>> struct dict_iterator iter;
>> +#endif
>
> Can you explain why using #if 0 instead of deleting these variables?
>
Because they are used in the #if 0 block just below.
Alternatively, we could remove both the variables and the #if 0 block.
Michael
prev parent reply other threads:[~2010-05-07 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 23:39 Michael Snyder
2010-05-07 3:17 ` Joel Brobecker
2010-05-07 17:29 ` Tom Tromey
2010-05-17 17:24 ` Joel Brobecker
2010-05-07 18:23 ` Michael Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE45AA1.4080706@vmware.com \
--to=msnyder@vmware.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox