From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72902-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19398 invoked by alias); 7 May 2010 18:23:35 -0000
Received: (qmail 19388 invoked by uid 22791); 7 May 2010 18:23:35 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,TW_BJ,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 May 2010 18:23:31 +0000
Received: from jupiter.vmware.com (mailhost5.vmware.com [10.16.68.131])	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id A4F773003B;	Fri,  7 May 2010 11:23:29 -0700 (PDT)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by jupiter.vmware.com (Postfix) with ESMTP id 9D81ADC392;	Fri,  7 May 2010 11:23:29 -0700 (PDT)
Message-ID: <4BE45AA1.4080706@vmware.com>
Date: Fri, 07 May 2010 18:23:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.22 (X11/20090609)
MIME-Version: 1.0
To: Joel Brobecker <brobecker@adacore.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] ada-lang, c-lang, f-lang, objc-lang, jv-lang, m2-lang, ada-tasks.c: delete unused variables
References: <4BE35310.9020704@vmware.com> <20100507031644.GZ2768@adacore.com>
In-Reply-To: <20100507031644.GZ2768@adacore.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00195.txt.bz2

Joel Brobecker wrote:
>> --- jv-lang.c	22 Apr 2010 23:15:41 -0000	1.83
>> +++ jv-lang.c	6 May 2010 23:35:37 -0000
>> @@ -268,8 +268,10 @@ type_from_class (struct gdbarch *gdbarch
>>    struct value *utf8_name;
>>    char *nptr;
>>    CORE_ADDR addr;
>> +#if 0
>>    struct block *bl;
>>    struct dict_iterator iter;
>> +#endif
> 
> Can you explain why using #if 0 instead of deleting these variables?
> 

Because they are used in the #if 0 block just below.

Alternatively, we could remove both the variables and the #if 0 block.

Michael