Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Stan Shebs <stan@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] One more for MI trace status
Date: Fri, 09 Apr 2010 20:55:00 -0000	[thread overview]
Message-ID: <4BBF9429.4090804@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

There is one more field that's been overlooked for trace_status_mi - 
total frames created.  (More trace status additions are coming, perhaps 
we should revisit the idea of sharing CLI and MI versions...)

I note that MI commands for tracing need testsuite.  But there's a 
conundrum; should tests go in gdb.mi or gdb.trace? :-)

Stan

2010-04-09  Stan Shebs  <stan@codesourcery.com>

    * tracepoint.c (trace_status_mi): Report frames created.

    * gdb.texinfo (gdb/mi Tracepoint Commands) <-trace-status>:
    Describe the `frames-created' field, tweak grammar.




[-- Attachment #2: micreated-patch-1 --]
[-- Type: text/plain, Size: 2057 bytes --]

Index: tracepoint.c
===================================================================
RCS file: /cvs/src/src/gdb/tracepoint.c,v
retrieving revision 1.176
diff -p -r1.176 tracepoint.c
*** tracepoint.c	9 Apr 2010 19:34:57 -0000	1.176
--- tracepoint.c	9 Apr 2010 20:45:14 -0000
*************** trace_status_mi (int on_stop)
*** 1798,1803 ****
--- 1798,1805 ----
  
    if (ts->traceframe_count != -1)
      ui_out_field_int (uiout, "frames", ts->traceframe_count);
+   if (ts->traceframes_created != -1)
+     ui_out_field_int (uiout, "frames-created", ts->traceframes_created);
    if (ts->buffer_size != -1)
      ui_out_field_int (uiout, "buffer-size", ts->buffer_size);
    if (ts->buffer_free != -1)
Index: doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.702
diff -p -r1.702 gdb.texinfo
*** doc/gdb.texinfo	9 Apr 2010 15:22:09 -0000	1.702
--- doc/gdb.texinfo	9 Apr 2010 20:45:15 -0000
*************** present iff the @samp{stop-reason} field
*** 26421,26433 ****
  @samp{passcount}.
  
  @item frames
! This field is an integer number of currently collected frames.  This
! field is optional.
  
  @item buffer-size
  @itemx buffer-free
  These fields tell the current size of the tracing buffer and the
! remaining space.  These field is optional.
  
  @item circular
  The value of the circular trace buffer flag.  @code{1} means that the
--- 26421,26436 ----
  @samp{passcount}.
  
  @item frames
! @itemx frames-created
! The @samp{frames} field is a count of the total number of trace frames
! in the trace buffer, while @samp{frames-created} is the total created
! during the run, including ones that were discarded, such as when a
! circular trace buffer filled up.  Both fields are optional.
  
  @item buffer-size
  @itemx buffer-free
  These fields tell the current size of the tracing buffer and the
! remaining space.  These fields are optional.
  
  @item circular
  The value of the circular trace buffer flag.  @code{1} means that the

             reply	other threads:[~2010-04-09 20:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-09 20:55 Stan Shebs [this message]
2010-04-10  0:11 ` Michael Snyder
2010-04-10  6:56 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BBF9429.4090804@codesourcery.com \
    --to=stan@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox