From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9594 invoked by alias); 9 Apr 2010 20:55:24 -0000 Received: (qmail 9290 invoked by uid 22791); 9 Apr 2010 20:55:22 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Apr 2010 20:55:18 +0000 Received: (qmail 12915 invoked from network); 9 Apr 2010 20:55:17 -0000 Received: from unknown (HELO macbook-2.local) (stan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 Apr 2010 20:55:17 -0000 Message-ID: <4BBF9429.4090804@codesourcery.com> Date: Fri, 09 Apr 2010 20:55:00 -0000 From: Stan Shebs User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228) MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: [PATCH] One more for MI trace status Content-Type: multipart/mixed; boundary="------------000406000607080700020606" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00286.txt.bz2 This is a multi-part message in MIME format. --------------000406000607080700020606 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 570 There is one more field that's been overlooked for trace_status_mi - total frames created. (More trace status additions are coming, perhaps we should revisit the idea of sharing CLI and MI versions...) I note that MI commands for tracing need testsuite. But there's a conundrum; should tests go in gdb.mi or gdb.trace? :-) Stan 2010-04-09 Stan Shebs * tracepoint.c (trace_status_mi): Report frames created. * gdb.texinfo (gdb/mi Tracepoint Commands) <-trace-status>: Describe the `frames-created' field, tweak grammar. --------------000406000607080700020606 Content-Type: text/plain; x-mac-type="0"; x-mac-creator="0"; name="micreated-patch-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="micreated-patch-1" Content-length: 2057 Index: tracepoint.c =================================================================== RCS file: /cvs/src/src/gdb/tracepoint.c,v retrieving revision 1.176 diff -p -r1.176 tracepoint.c *** tracepoint.c 9 Apr 2010 19:34:57 -0000 1.176 --- tracepoint.c 9 Apr 2010 20:45:14 -0000 *************** trace_status_mi (int on_stop) *** 1798,1803 **** --- 1798,1805 ---- if (ts->traceframe_count != -1) ui_out_field_int (uiout, "frames", ts->traceframe_count); + if (ts->traceframes_created != -1) + ui_out_field_int (uiout, "frames-created", ts->traceframes_created); if (ts->buffer_size != -1) ui_out_field_int (uiout, "buffer-size", ts->buffer_size); if (ts->buffer_free != -1) Index: doc/gdb.texinfo =================================================================== RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v retrieving revision 1.702 diff -p -r1.702 gdb.texinfo *** doc/gdb.texinfo 9 Apr 2010 15:22:09 -0000 1.702 --- doc/gdb.texinfo 9 Apr 2010 20:45:15 -0000 *************** present iff the @samp{stop-reason} field *** 26421,26433 **** @samp{passcount}. @item frames ! This field is an integer number of currently collected frames. This ! field is optional. @item buffer-size @itemx buffer-free These fields tell the current size of the tracing buffer and the ! remaining space. These field is optional. @item circular The value of the circular trace buffer flag. @code{1} means that the --- 26421,26436 ---- @samp{passcount}. @item frames ! @itemx frames-created ! The @samp{frames} field is a count of the total number of trace frames ! in the trace buffer, while @samp{frames-created} is the total created ! during the run, including ones that were discarded, such as when a ! circular trace buffer filled up. Both fields are optional. @item buffer-size @itemx buffer-free These fields tell the current size of the tracing buffer and the ! remaining space. These fields are optional. @item circular The value of the circular trace buffer flag. @code{1} means that the --------------000406000607080700020606--