From: Stan Shebs <stan@codesourcery.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Stan Shebs <stan@codesourcery.com>
Subject: Re: [PATCH] More C++ for tracepoint actions
Date: Tue, 16 Mar 2010 00:05:00 -0000 [thread overview]
Message-ID: <4B9ECB47.304@codesourcery.com> (raw)
In-Reply-To: <201003120127.40475.pedro@codesourcery.com>
Pedro Alves wrote:
> I got comments :-)
>
> On Friday 12 March 2010 01:05:58, Stan Shebs wrote:
>
>> + static int
>> + gen_maybe_namespace_elt (struct expression *exp,
>> + struct agent_expr *ax, struct axs_value *value,
>> + const struct type *curtype, char *name)
>> + {
>> + const char *namespace_name = TYPE_TAG_NAME (curtype);
>> + struct symbol *sym;
>> +
>> + sym = cp_lookup_symbol_namespace (namespace_name, name,
>> + get_selected_block (0),
>>
>
> This should be context of the tracepoint instead:
>
> block_for_pc (ax->scope)
>
Thanks for the catch! Committed with that change.
Stan
prev parent reply other threads:[~2010-03-16 0:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 1:06 Stan Shebs
2010-03-12 1:27 ` Pedro Alves
2010-03-16 0:05 ` Stan Shebs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9ECB47.304@codesourcery.com \
--to=stan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox