From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8275 invoked by alias); 16 Mar 2010 00:05:38 -0000 Received: (qmail 8265 invoked by uid 22791); 16 Mar 2010 00:05:37 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Mar 2010 00:05:34 +0000 Received: (qmail 14470 invoked from network); 16 Mar 2010 00:05:32 -0000 Received: from unknown (HELO macbook-2.local) (stan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 16 Mar 2010 00:05:32 -0000 Message-ID: <4B9ECB47.304@codesourcery.com> Date: Tue, 16 Mar 2010 00:05:00 -0000 From: Stan Shebs User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: Pedro Alves CC: gdb-patches@sourceware.org, Stan Shebs Subject: Re: [PATCH] More C++ for tracepoint actions References: <4B999376.8030209@codesourcery.com> <201003120127.40475.pedro@codesourcery.com> In-Reply-To: <201003120127.40475.pedro@codesourcery.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00567.txt.bz2 Pedro Alves wrote: > I got comments :-) > > On Friday 12 March 2010 01:05:58, Stan Shebs wrote: > >> + static int >> + gen_maybe_namespace_elt (struct expression *exp, >> + struct agent_expr *ax, struct axs_value *value, >> + const struct type *curtype, char *name) >> + { >> + const char *namespace_name = TYPE_TAG_NAME (curtype); >> + struct symbol *sym; >> + >> + sym = cp_lookup_symbol_namespace (namespace_name, name, >> + get_selected_block (0), >> > > This should be context of the tracepoint instead: > > block_for_pc (ax->scope) > Thanks for the catch! Committed with that change. Stan