From: Jie Zhang <jie@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Mike Frysinger <vapier@gentoo.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: tests/monitor: set remotetimeout to gdb_load_timeout for remote targets
Date: Mon, 15 Mar 2010 03:56:00 -0000 [thread overview]
Message-ID: <4B9DAFF0.4060508@codesourcery.com> (raw)
In-Reply-To: <20100315004225.GD3045@adacore.com>
On 03/15/2010 08:42 AM, Joel Brobecker wrote:
>> * gdb/testsuite/config/monitor.exp (gdb_load): New decimal variable.
>> Save remotetimeout setting in oldremotetimeout. Set remotetimeout to
>> $loadtimeout. Restore when done.
>
> Do you have to use send_gdb/gdb_expect in this file, or can you use
> gdb_test, or gdb_test_multiple?
>
> Watch out for stray semicolon at the end of a few statements. Eg:
>
>> + send_gdb "set remotetimeout $oldremotetimeout\n";
> ^^^
I will see if I can find some time later today to fix these. Thanks for
review.
--
Jie Zhang
CodeSourcery
(650) 331-3385 x735
next prev parent reply other threads:[~2010-03-15 3:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-14 22:01 Mike Frysinger
2010-03-15 0:42 ` Joel Brobecker
2010-03-15 3:56 ` Jie Zhang [this message]
2010-03-15 1:52 ` Jie Zhang
2010-03-15 7:16 ` Mike Frysinger
2011-06-05 21:34 Mike Frysinger
2011-06-18 22:31 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9DAFF0.4060508@codesourcery.com \
--to=jie@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox