From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4558 invoked by alias); 15 Mar 2010 03:56:51 -0000 Received: (qmail 4543 invoked by uid 22791); 15 Mar 2010 03:56:50 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Mar 2010 03:56:45 +0000 Received: (qmail 29829 invoked from network); 15 Mar 2010 03:56:44 -0000 Received: from unknown (HELO ?192.168.0.124?) (jie@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Mar 2010 03:56:44 -0000 Message-ID: <4B9DAFF0.4060508@codesourcery.com> Date: Mon, 15 Mar 2010 03:56:00 -0000 From: Jie Zhang User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 To: Joel Brobecker CC: Mike Frysinger , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: tests/monitor: set remotetimeout to gdb_load_timeout for remote targets References: <1268604157-26405-1-git-send-email-vapier@gentoo.org> <20100315004225.GD3045@adacore.com> In-Reply-To: <20100315004225.GD3045@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00528.txt.bz2 On 03/15/2010 08:42 AM, Joel Brobecker wrote: >> * gdb/testsuite/config/monitor.exp (gdb_load): New decimal variable. >> Save remotetimeout setting in oldremotetimeout. Set remotetimeout to >> $loadtimeout. Restore when done. > > Do you have to use send_gdb/gdb_expect in this file, or can you use > gdb_test, or gdb_test_multiple? > > Watch out for stray semicolon at the end of a few statements. Eg: > >> + send_gdb "set remotetimeout $oldremotetimeout\n"; > ^^^ I will see if I can find some time later today to fix these. Thanks for review. -- Jie Zhang CodeSourcery (650) 331-3385 x735