Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Masaki Muranaka <monaka@monami-software.com>
Cc: Daniel Jacobowitz <drow@false.org>,
	gdb-patches@sourceware.org,         binutils@sourceware.org
Subject: Re: Can't set architecture to m32c on m32c-elf-gdb.
Date: Thu, 07 Jan 2010 15:54:00 -0000	[thread overview]
Message-ID: <4B460270.5060808@redhat.com> (raw)
In-Reply-To: <271DFD02-74A7-4296-8253-AF4E24A38ADA@monami-software.com>

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

Hi Masaki,

> Please try 'print $dma0' on GDB (w/o my patch).
> dma0 is a register supported by m32c only.
> So the result of 'print $dma0' is ...
> In case m32c, it should be 'No registers.'
> In case m16c, it should be ''void' since it doesn't have dma0 register.

Thank you - that was the extra information that I needed in order to be 
able to diagnose this problem.

Please try out the attached patch and let me know if it works for you.

By the way, this has exposed a problem with GDB's set architecture 
command - it is not set up to allow the "ARCH:MACH" notation that is 
accepted by the BFD library.  Maybe someone will want to fix this one day...

Cheers
   Nick


[-- Attachment #2: cpu-m32c.c.patch --]
[-- Type: text/x-diff, Size: 1940 bytes --]

Index: bfd/cpu-m32c.c
===================================================================
RCS file: /cvs/src/src/bfd/cpu-m32c.c,v
retrieving revision 1.4
diff -c -3 -p -r1.4 cpu-m32c.c
*** bfd/cpu-m32c.c	2 Sep 2009 07:18:36 -0000	1.4
--- bfd/cpu-m32c.c	7 Jan 2010 15:44:35 -0000
***************
*** 22,27 ****
--- 22,40 ----
  #include "bfd.h"
  #include "libbfd.h"
  
+ /* Like bfd_default_scan but if the string is just "m32c" then
+    skip the m16c architecture.  */
+ 
+ static bfd_boolean
+ m32c_scan (const bfd_arch_info_type * info, const char * string)
+ {
+   if (strcmp (string, "m32c") == 0
+       && info->mach == bfd_mach_m16c)
+     return FALSE;
+ 
+   return bfd_default_scan (info, string);
+ }
+ 
  static const bfd_arch_info_type arch_info_struct[] =
  {
    {
*************** static const bfd_arch_info_type arch_inf
*** 35,41 ****
      3,				/* section align power */
      FALSE,			/* the default ? */
      bfd_default_compatible,	/* architecture comparison fn */
!     bfd_default_scan,		/* string to architecture convert fn */
      NULL			/* next in list */
    },
  };
--- 48,54 ----
      3,				/* section align power */
      FALSE,			/* the default ? */
      bfd_default_compatible,	/* architecture comparison fn */
!     m32c_scan,			/* string to architecture convert fn */
      NULL			/* next in list */
    },
  };
*************** const bfd_arch_info_type bfd_m32c_arch =
*** 52,57 ****
    4,				/* Section align power.  */
    TRUE,				/* The default ?  */
    bfd_default_compatible,	/* Architecture comparison fn.  */
!   bfd_default_scan,		/* String to architecture convert fn.  */
    &arch_info_struct[0],		/* Next in list.  */
  };
--- 65,70 ----
    4,				/* Section align power.  */
    TRUE,				/* The default ?  */
    bfd_default_compatible,	/* Architecture comparison fn.  */
!   m32c_scan,			/* String to architecture convert fn.  */
    &arch_info_struct[0],		/* Next in list.  */
  };

  reply	other threads:[~2010-01-07 15:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-03  9:17 Masaki Muranaka
2008-12-03 14:08 ` Daniel Jacobowitz
2008-12-04  1:04   ` Masaki Muranaka
2008-12-04  4:27     ` Daniel Jacobowitz
2008-12-04  6:48       ` Masaki Muranaka
2008-12-04 13:13         ` Daniel Jacobowitz
2008-12-04 14:22           ` Pedro Alves
2008-12-05  0:29             ` Masaki Muranaka
2009-12-28  2:32   ` Masaki Muranaka
2009-12-31 12:22     ` Nick Clifton
2010-01-03  0:00       ` Masaki Muranaka
2010-01-06  8:18         ` [patch] " Masaki Muranaka
2010-01-06 15:17         ` Nick Clifton
2010-01-06 23:24           ` Masaki Muranaka
2010-01-07 15:54             ` Nick Clifton [this message]
2010-01-07 22:38               ` Masaki Muranaka
2010-01-07 22:45                 ` DJ Delorie
2010-01-08  0:02                   ` Masaki Muranaka
2010-01-08  0:07                     ` DJ Delorie
2010-01-08  0:45                       ` Masaki Muranaka
2010-01-08 11:40                 ` Nick Clifton
2010-01-12  0:04                   ` Masaki Muranaka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B460270.5060808@redhat.com \
    --to=nickc@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=monaka@monami-software.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox