Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA/RFC] Prec multi-thread support [1/4] X86 insn support
Date: Wed, 25 Nov 2009 20:04:00 -0000	[thread overview]
Message-ID: <4B0D8CE2.50009@vmware.com> (raw)
In-Reply-To: <daef60380911250005j6283fcb2sa7cf9e351b8c01cc@mail.gmail.com>

This one looks fine to me.

Hui Zhu wrote:
> When I debug i386 multi-thread inferior, it need support int3 and
> rdtsc.  So make a patch to support them.
> 
> 2009-11-24  Hui Zhu  <teawater@gmail.com>
> 
> 	* i386-tdep.c (i386_process_record): Add code for int3 and rdtsc.
> 
> ---
>  i386-tdep.c |   10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> --- a/i386-tdep.c
> +++ b/i386-tdep.c
> @@ -4847,10 +4847,6 @@ reswitch:
>        /* int3 */
>        /* XXX */
>      case 0xcc:
> -      printf_unfiltered (_("Process record doesn't support instruction "
> -               "int3.\n"));
> -      ir.addr -= 1;
> -      goto no_support;
>        break;
> 
>        /* int */
> @@ -4958,10 +4954,8 @@ reswitch:
> 
>        /* rdtsc */
>      case 0x0f31:
> -      printf_unfiltered (_("Process record doesn't support "
> -               "instruction rdtsc.\n"));
> -      ir.addr -= 2;
> -      goto no_support;
> +      I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_REAX_REGNUM);
> +      I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_REDX_REGNUM);
>        break;
> 
>        /* sysenter */


  parent reply	other threads:[~2009-11-25 20:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25  8:06 Hui Zhu
2009-11-25 10:44 ` Mark Kettenis
2009-11-25 10:57   ` Hui Zhu
2009-11-25 20:04 ` Michael Snyder [this message]
2009-11-30 19:58 ` Tom Tromey
2009-12-08  5:53   ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0D8CE2.50009@vmware.com \
    --to=msnyder@vmware.com \
    --cc=gdb-patches@sourceware.org \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox