From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68651-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26863 invoked by alias); 25 Nov 2009 20:04:49 -0000
Received: (qmail 26609 invoked by uid 22791); 25 Nov 2009 20:04:47 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Nov 2009 20:04:43 +0000
Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) 	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 1270049087; 	Wed, 25 Nov 2009 12:04:42 -0800 (PST)
Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) 	by mailhost4.vmware.com (Postfix) with ESMTP id 08D3CC9A1D; 	Wed, 25 Nov 2009 12:04:42 -0800 (PST)
Message-ID: <4B0D8CE2.50009@vmware.com>
Date: Wed, 25 Nov 2009 20:04:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20090624)
MIME-Version: 1.0
To: Hui Zhu <teawater@gmail.com>
CC: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA/RFC] Prec multi-thread support [1/4] X86 insn support
References: <daef60380911250005j6283fcb2sa7cf9e351b8c01cc@mail.gmail.com>
In-Reply-To: <daef60380911250005j6283fcb2sa7cf9e351b8c01cc@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-11/txt/msg00558.txt.bz2

This one looks fine to me.

Hui Zhu wrote:
> When I debug i386 multi-thread inferior, it need support int3 and
> rdtsc.  So make a patch to support them.
> 
> 2009-11-24  Hui Zhu  <teawater@gmail.com>
> 
> 	* i386-tdep.c (i386_process_record): Add code for int3 and rdtsc.
> 
> ---
>  i386-tdep.c |   10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> --- a/i386-tdep.c
> +++ b/i386-tdep.c
> @@ -4847,10 +4847,6 @@ reswitch:
>        /* int3 */
>        /* XXX */
>      case 0xcc:
> -      printf_unfiltered (_("Process record doesn't support instruction "
> -               "int3.\n"));
> -      ir.addr -= 1;
> -      goto no_support;
>        break;
> 
>        /* int */
> @@ -4958,10 +4954,8 @@ reswitch:
> 
>        /* rdtsc */
>      case 0x0f31:
> -      printf_unfiltered (_("Process record doesn't support "
> -               "instruction rdtsc.\n"));
> -      ir.addr -= 2;
> -      goto no_support;
> +      I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_REAX_REGNUM);
> +      I386_RECORD_ARCH_LIST_ADD_REG (X86_RECORD_REDX_REGNUM);
>        break;
> 
>        /* sysenter */