From: Andrew Stubbs <ams@codesourcery.com>
To: gdb-patches@sourceware.org,
"Maciej W. Rozycki" <macro@codesourcery.com>,
Vladimir Prus <vladimir@codesourcery.com>,
Eli Zaretskii <eliz@gnu.org>
Subject: Re: RFC: Fix "break *EXP thread NUM"
Date: Tue, 24 Nov 2009 10:33:00 -0000 [thread overview]
Message-ID: <4B0BB652.3080303@codesourcery.com> (raw)
In-Reply-To: <20091123212736.GA3828@caradoc.them.org>
On 23/11/09 21:27, Daniel Jacobowitz wrote:
> In this patch, I have taken advantage of the fact that even if you
> have a local variable named "thread", there is no valid C expression
> which has a variable name, whitespace, and an integer or floating
> point constant. So "thread [0-9]" can also safely be treated
> as an expression terminator.
>
> Does anyone see a problem with this approach?
Unfortunately, I can. :(
It's also valid to say, for example:
(gdb) b main t 999
Unknown thread 999.
or
(gdb) b main thread -10
Unknown thread -10.
or indeed
(gdb) b main thread +10
Unknown thread 10.
Hex and octal are also allowed, but since they always start with zero, I
think you have them covered.
Andrew
next prev parent reply other threads:[~2009-11-24 10:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-23 21:27 Daniel Jacobowitz
2009-11-24 0:21 ` Joel Brobecker
2009-11-24 10:33 ` Andrew Stubbs [this message]
2009-11-24 14:24 ` Daniel Jacobowitz
2009-11-24 14:54 ` Joel Brobecker
2009-11-24 15:05 ` Daniel Jacobowitz
2009-11-25 20:43 ` Daniel Jacobowitz
2009-12-01 19:53 ` Maciej W. Rozycki
2009-12-01 20:04 ` Daniel Jacobowitz
2010-01-01 6:31 ` [commit] Fix "break *EXP thread/task NUM" for Ada (was: "Re: RFC: Fix "break *EXP thread NUM"") Joel Brobecker
2009-11-24 17:08 ` RFC: Fix "break *EXP thread NUM" Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0BB652.3080303@codesourcery.com \
--to=ams@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=macro@codesourcery.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox