From: Keith Seitz <keiths@redhat.com>
To: tromey@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Add parsing support for C++ operators
Date: Wed, 11 Nov 2009 16:47:00 -0000 [thread overview]
Message-ID: <4AFAEA84.8090705@redhat.com> (raw)
In-Reply-To: <m3fx8l6qps.fsf@fleche.redhat.com>
On 11/11/2009 07:11 AM, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz<keiths@redhat.com> writes:
> Keith> + | OPERATOR ptype
> Keith> + { char *name;
> Keith> + long length;
> Keith> + struct ui_file *buf = mem_fileopen ();
> Keith> +
> Keith> + c_print_type ($2, NULL, buf, -1, 0);
> Keith> + name = ui_file_xstrdup (buf,&length);
> Keith> + ui_file_delete (buf);
> Keith> + $$ = operator_stoken (name);
>
> This leaks 'name', you need a free after the call to operator_stoken.
Indeed! Overzealous pre-submission cleanup...
> This is ok with the above change. Thanks.
I have committed this patch. Thank you for reviewing it.
Keith
next prev parent reply other threads:[~2009-11-11 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 0:51 Keith Seitz
2009-11-11 15:12 ` Tom Tromey
2009-11-11 16:47 ` Keith Seitz [this message]
2009-11-21 5:17 ` Pedro Alves
2009-11-21 19:05 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFAEA84.8090705@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox