Re: [RFA] Add parsing support for C++ operators

[Pedro Alves <pedro@codesourcery.com>]

On Wednesday 11 November 2009 00:51:31, Keith Seitz wrote:
> +    set expected [regsub {\(void\)} $name {()}]

> +    set demangled [regsub {\\\(void\\\)} $demangled {\(\)}]

This syntax doesn't work on older tcl's:

ERROR: tcl error sourcing ../../../src/gdb/testsuite/gdb.cp/cplusfuncs.exp.
ERROR: wrong # args: should be "regsub ?switches? exp string subSpec varName"
    while executing
"regsub {\(void\)} $name {()}"
    (procedure "print_addr" line 2)
    invoked from within
"print_addr "overload1arg($dm_type_void)""
:

I'm applying the fix below to use the old regsub syntax.
(this patch doesn't conflict with your pending patches)

Keith, I've found a similar issue in your new cpexprs.exp test.
I'm using this local change on top of your patch:

Index: src/gdb/testsuite/gdb.cp/cpexprs.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.cp/cpexprs.exp   2009-11-21 01:26:00.000000000 +0000
+++ src/gdb/testsuite/gdb.cp/cpexprs.exp        2009-11-21 01:26:13.000000000 +0000
@@ -73,7 +73,7 @@ proc add {func type print lst} {

     # An exception: since gdb canonicalizes C++ output,
     # "(void)" must be mutated to "()".
-    set print [regsub {\(void\)} $print {()}]
+    regsub {\(void\)} $print {()} print

-- 
Pedro Alves


2009-11-21  Pedro Alves  <pedro@codesourcery.com>

	* gdb.cp/cplusfuncs.exp (info_func_regexp, print_addr): Don't
	assume new `regsub' syntax available.

---
 gdb/testsuite/gdb.cp/cplusfuncs.exp |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: src/gdb/testsuite/gdb.cp/cplusfuncs.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.cp/cplusfuncs.exp	2009-11-21 01:42:01.000000000 +0000
+++ src/gdb/testsuite/gdb.cp/cplusfuncs.exp	2009-11-21 01:43:25.000000000 +0000
@@ -241,7 +241,7 @@ proc info_func_regexp { name demangled }
     global gdb_prompt
 
     send_gdb "info function $name\n"
-    set demangled [regsub {\\\(void\\\)} $demangled {\(\)}]
+    regsub {\\\(void\\\)} $demangled {\(\)} demangled
     gdb_expect {
 	-re ".*File .*:\r\n(class |)$demangled\r\n.*$gdb_prompt $" {
 	    pass "info function for \"$name\""
@@ -328,7 +328,7 @@ proc print_addr_2_kfail { name good bad 
 #
 
 proc print_addr { name } {
-    set expected [regsub {\(void\)} $name {()}]
+    regsub {\(void\)} $name {()} expected
     if {[string first "::" $name] == -1} {
 	# C function -- must be qutoed
 	set name "'$name'"