From: Nathan Sidwell <nathan@codesourcery.com>
To: Nathan Sidwell <nathan@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: fileio test
Date: Tue, 10 Nov 2009 10:55:00 -0000 [thread overview]
Message-ID: <4AF94694.1090601@codesourcery.com> (raw)
In-Reply-To: <20091109201406.GA9160@caradoc.them.org>
Daniel Jacobowitz wrote:
> On Thu, Nov 05, 2009 at 06:04:18PM +0000, Nathan Sidwell wrote:
>> This patch fixes an augments the fileio shell test. By default
>> system calls are disallowed -- but the test expects them to be
>> enabled. This patch fixes that test and verifies that enabling
>> system calls, does indeed enable them.
>>
>> ok?
>
> What happens when you run this test natively? I believe it will fail
> since it uses your host's system () directly. This test doesn't test
> just fileio.
ah, yes you're right. The current behaviour passes natively because of that.
It's not obvious to me how the testsuite could distinguish between these two
cases. remote-fileio.c doesn't have any verbose logging we could turn on (and
have the testsuite watch for it). I suppose we could add it. Or we could turn
on remote-protocol logging and watch for that (which seems less desirable).
Thoughts?
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery
next prev parent reply other threads:[~2009-11-10 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 18:04 Nathan Sidwell
2009-11-09 20:14 ` Daniel Jacobowitz
2009-11-10 10:55 ` Nathan Sidwell [this message]
2009-11-10 19:12 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF94694.1090601@codesourcery.com \
--to=nathan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox