From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21700 invoked by alias); 10 Nov 2009 10:55:28 -0000 Received: (qmail 21692 invoked by uid 22791); 10 Nov 2009 10:55:27 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Nov 2009 10:55:22 +0000 Received: (qmail 3716 invoked from network); 10 Nov 2009 10:55:20 -0000 Received: from unknown (HELO ?192.168.44.101?) (nathan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 Nov 2009 10:55:20 -0000 Message-ID: <4AF94694.1090601@codesourcery.com> Date: Tue, 10 Nov 2009 10:55:00 -0000 From: Nathan Sidwell User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Nathan Sidwell , gdb-patches@sourceware.org Subject: Re: fileio test References: <4AF313A2.3000907@codesourcery.com> <20091109201406.GA9160@caradoc.them.org> In-Reply-To: <20091109201406.GA9160@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00210.txt.bz2 Daniel Jacobowitz wrote: > On Thu, Nov 05, 2009 at 06:04:18PM +0000, Nathan Sidwell wrote: >> This patch fixes an augments the fileio shell test. By default >> system calls are disallowed -- but the test expects them to be >> enabled. This patch fixes that test and verifies that enabling >> system calls, does indeed enable them. >> >> ok? > > What happens when you run this test natively? I believe it will fail > since it uses your host's system () directly. This test doesn't test > just fileio. ah, yes you're right. The current behaviour passes natively because of that. It's not obvious to me how the testsuite could distinguish between these two cases. remote-fileio.c doesn't have any verbose logging we could turn on (and have the testsuite watch for it). I suppose we could add it. Or we could turn on remote-protocol logging and watch for that (which seems less desirable). Thoughts? nathan -- Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery