From: Keith Seitz <keiths@redhat.com>
To: tromey@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Add method overload resolution to expression parser
Date: Mon, 09 Nov 2009 23:35:00 -0000 [thread overview]
Message-ID: <4AF8A740.8000305@redhat.com> (raw)
In-Reply-To: <m3bpjbe3ts.fsf@fleche.redhat.com>
On 11/09/2009 02:22 PM, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz<keiths@redhat.com> writes:
> These frees should be done with cleanups, in case
> evaluate_subexp_standard throws an exception.
> I think free_param_types was ok, it was just that the cleanup was made in
> a surprising place (make_params) and not run at the "right point" (just
> before the end of the TYPE_INSTANCE case).
Okay, I apologize -- I *completely* misunderstood what you were saying.
I've corrected this again. O:-)
>
> This is ok with that change. Thanks.
I'll wait a day to see if Daniel (or anyone else) has any other concerns
before committing this. In the meantime, I'll see about digging up
another expr-cumulative patch or two.
Thank you for your reviewing the patch.
Keith
next prev parent reply other threads:[~2009-11-09 23:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 18:06 Keith Seitz
2009-09-24 19:30 ` Keith Seitz
2009-10-13 21:24 ` Daniel Jacobowitz
2009-10-14 18:54 ` Tom Tromey
2009-10-14 19:17 ` Daniel Jacobowitz
2009-10-14 19:29 ` Tom Tromey
2009-10-13 21:24 ` Tom Tromey
2009-11-09 21:55 ` Keith Seitz
2009-11-09 22:22 ` Tom Tromey
2009-11-09 23:35 ` Keith Seitz [this message]
2009-11-10 19:14 ` Daniel Jacobowitz
2009-11-10 22:19 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF8A740.8000305@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox