From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13853 invoked by alias); 9 Nov 2009 23:35:37 -0000 Received: (qmail 13845 invoked by uid 22791); 9 Nov 2009 23:35:37 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Nov 2009 23:35:33 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA9NZVJQ012314 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 9 Nov 2009 18:35:31 -0500 Received: from [IPv6:::1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nA9NZSHf019403 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 9 Nov 2009 18:35:30 -0500 Message-ID: <4AF8A740.8000305@redhat.com> Date: Mon, 09 Nov 2009 23:35:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4 MIME-Version: 1.0 To: tromey@redhat.com CC: gdb-patches@sourceware.org Subject: Re: [RFA] Add method overload resolution to expression parser References: <4A9D628B.1070300@redhat.com> <4AF88FD4.2010303@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00199.txt.bz2 On 11/09/2009 02:22 PM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > These frees should be done with cleanups, in case > evaluate_subexp_standard throws an exception. > I think free_param_types was ok, it was just that the cleanup was made in > a surprising place (make_params) and not run at the "right point" (just > before the end of the TYPE_INSTANCE case). Okay, I apologize -- I *completely* misunderstood what you were saying. I've corrected this again. O:-) > > This is ok with that change. Thanks. I'll wait a day to see if Daniel (or anyone else) has any other concerns before committing this. In the meantime, I'll see about digging up another expr-cumulative patch or two. Thank you for your reviewing the patch. Keith