Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	  "teawater@gmail.com" <teawater@gmail.com>
Subject: Re: [RFA, 2 of 3] save/restore process record, part 2 (core ops target)
Date: Thu, 22 Oct 2009 19:43:00 -0000	[thread overview]
Message-ID: <4AE0B440.1090804@vmware.com> (raw)
In-Reply-To: <83oco5hk3y.fsf@gnu.org>

Eli Zaretskii wrote:
>> Date: Sat, 17 Oct 2009 10:08:50 -0700
>> From: Michael Snyder <msnyder@vmware.com>
>> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, 
>>  "teawater@gmail.com" <teawater@gmail.com>
>>
>> This is a multi-part message in MIME format.
>> --------------040403070509020904040303
>> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>> Content-Transfer-Encoding: 7bit
>>
>> Eli Zaretskii wrote:
>>>> Date: Fri, 16 Oct 2009 18:24:43 -0700
>>>> From: Michael Snyder <msnyder@vmware.com>
>>>>
>>>> +  if (!tmp_to_resume)
>>>> +    error (_("Process record can't get to_resume."));
>>>> +  if (!tmp_to_wait)
>>>> +    error (_("Process record can't get to_wait."));
>>>> +  if (!tmp_to_store_registers)
>>>> +    error (_("Process record can't get to_store_registers."));
>>>> +  if (!tmp_to_insert_breakpoint)
>>>> +    error (_("Process record can't get to_insert_breakpoint."));
>>>> +  if (!tmp_to_remove_breakpoint)
>>>> +    error (_("Process record can't get to_remove_breakpoint."));
>>> Can we rephrase these to be more user-friendly?  As written, this text
>>> is okay for debug printouts, but not for user-level error messages,
>>> IMO.  (Yes, I know this text was in the old version, but still...)
>> No problem, see revised diff (attached).  However, in the unlikely
>> event that these occur, there won't be anything that the user can
>> do about it.
> 
> Thanks, the revised text is fine with me.
> 

And committed.


  reply	other threads:[~2009-10-22 19:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-17  1:30 Michael Snyder
2009-10-17  8:07 ` Eli Zaretskii
2009-10-17 17:14   ` Michael Snyder
2009-10-17 19:56     ` Eli Zaretskii
2009-10-22 19:43       ` Michael Snyder [this message]
2009-10-18  7:26     ` Hui Zhu
2009-10-18 17:31       ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE0B440.1090804@vmware.com \
    --to=msnyder@vmware.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox