From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-67913-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18928 invoked by alias); 22 Oct 2009 19:43:18 -0000
Received: (qmail 18918 invoked by uid 22791); 22 Oct 2009 19:43:17 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Oct 2009 19:43:14 +0000
Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) 	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 5F5D1131A0; 	Thu, 22 Oct 2009 12:43:13 -0700 (PDT)
Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) 	by mailhost2.vmware.com (Postfix) with ESMTP id 3E9848E8C4; 	Thu, 22 Oct 2009 12:43:13 -0700 (PDT)
Message-ID: <4AE0B440.1090804@vmware.com>
Date: Thu, 22 Oct 2009 19:43:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20080411)
MIME-Version: 1.0
To: Eli Zaretskii <eliz@gnu.org>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,   "teawater@gmail.com" <teawater@gmail.com>
Subject: Re: [RFA, 2 of 3] save/restore process record, part 2 (core ops target)
References: <4AD91CDB.5060002@vmware.com> <833a5iigxg.fsf@gnu.org> <4AD9FA22.9050604@vmware.com> <83oco5hk3y.fsf@gnu.org>
In-Reply-To: <83oco5hk3y.fsf@gnu.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-10/txt/msg00536.txt.bz2

Eli Zaretskii wrote:
>> Date: Sat, 17 Oct 2009 10:08:50 -0700
>> From: Michael Snyder <msnyder@vmware.com>
>> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, 
>>  "teawater@gmail.com" <teawater@gmail.com>
>>
>> This is a multi-part message in MIME format.
>> --------------040403070509020904040303
>> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>> Content-Transfer-Encoding: 7bit
>>
>> Eli Zaretskii wrote:
>>>> Date: Fri, 16 Oct 2009 18:24:43 -0700
>>>> From: Michael Snyder <msnyder@vmware.com>
>>>>
>>>> +  if (!tmp_to_resume)
>>>> +    error (_("Process record can't get to_resume."));
>>>> +  if (!tmp_to_wait)
>>>> +    error (_("Process record can't get to_wait."));
>>>> +  if (!tmp_to_store_registers)
>>>> +    error (_("Process record can't get to_store_registers."));
>>>> +  if (!tmp_to_insert_breakpoint)
>>>> +    error (_("Process record can't get to_insert_breakpoint."));
>>>> +  if (!tmp_to_remove_breakpoint)
>>>> +    error (_("Process record can't get to_remove_breakpoint."));
>>> Can we rephrase these to be more user-friendly?  As written, this text
>>> is okay for debug printouts, but not for user-level error messages,
>>> IMO.  (Yes, I know this text was in the old version, but still...)
>> No problem, see revised diff (attached).  However, in the unlikely
>> event that these occur, there won't be anything that the user can
>> do about it.
> 
> Thanks, the revised text is fine with me.
> 

And committed.