[RFA, 4 of 3] save/restore process record, part 4 (docs and news)

[RFA, 4 of 3] save/restore process record, part 4 (docs and news)

[Michael Snyder]

[-- Attachment #1: Type: text/plain, Size: 38 bytes --]

The fourth part of the trilogy.  ;-)


[-- Attachment #2: docs.txt --]
[-- Type: text/plain, Size: 2178 bytes --]

2009-10-17  Hui Zhu  <teawater@gmail.com>
	    Michael Snyder  <msnyder@vmware.com>

	* docs/gdb.texinfo: Document record save/restore commands.
	* NEWS: Mention record save/restore commands.

Index: NEWS
===================================================================
RCS file: /cvs/src/src/gdb/NEWS,v
retrieving revision 1.334
diff -u -p -r1.334 NEWS
--- NEWS	15 Oct 2009 19:28:52 -0000	1.334
+++ NEWS	17 Oct 2009 19:08:11 -0000
@@ -11,6 +11,11 @@ Xilinx MicroBlaze		microblaze-*-*
 
 Xilinx MicroBlaze		microblaze
 
+* New commands
+
+record save <filename> -- Save a 'process record' execution log to a file.
+record restore <filename -- Restore an earlier 'process record' session.
+
 *** Changes in GDB 7.0
 
 * GDB now has an interface for JIT compilation.  Applications that
Index: doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.633
diff -u -p -r1.633 gdb.texinfo
--- doc/gdb.texinfo	12 Oct 2009 01:59:54 -0000	1.633
+++ doc/gdb.texinfo	17 Oct 2009 19:08:12 -0000
@@ -5348,6 +5348,26 @@ When record target runs in replay mode (
 subsequent execution log and begin to record a new execution log starting
 from the current address.  This means you will abandon the previously
 recorded ``future'' and begin recording a new ``future''.
+
+@kindex record save
+@kindex rec save
+@item record save [@var{file}]
+@itemx rec save [@var{file}]
+Save the execution log of the inferior process into a modified core file.
+The optional argument @var{file} specifies the file name in which to
+save the execution log.  If not specified, the file name defaults
+to @file{gdb_record.@var{pid}}, where @var{pid} is is the PID of the
+inferior process.
+
+@kindex record restore
+@kindex rec restore
+@item record restore [@var{file}]
+@itemx rec restore [@var{file}]
+Restore the execution log of an earlier session from the file @var{file}
+(required), which has been created using the command @code{record save}.
+This execution log can then be debugged using the @code{process record}
+target, in replay mode, just like replaying a live debugging session.
+
 @end table
 
 

Re: [RFA, 4 of 3] save/restore process record, part 4 (docs and news)

[Eli Zaretskii]

> Date: Sat, 17 Oct 2009 12:05:27 -0700
> From: Michael Snyder <msnyder@vmware.com>
> 
> The fourth part of the trilogy.  ;-)

Thanks.

> 	* docs/gdb.texinfo: Document record save/restore commands.

This needs to state the name of the node where you made the changes.

> +* New commands
> +
> +record save <filename> -- Save a 'process record' execution log to a file.
> +record restore <filename -- Restore an earlier 'process record' session.

Please format these as we did with other new commands in NEWS.

> +Save the execution log of the inferior process into a modified core file.

"Modified" is too overloaded.  Suggest "specially formatted" instead.

> +This execution log can then be debugged using the @code{process record}

Well, you can't really "debug the execution log", can you?  How about

  You can then replay this execution log as if you recorded it in this
  @value{GDBN} session.

?

Re: [RFA, 4 of 3] save/restore process record, part 4 (docs and news)

[Michael Snyder]

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

Eli Zaretskii wrote:
>> Date: Sat, 17 Oct 2009 12:05:27 -0700
>> From: Michael Snyder <msnyder@vmware.com>
>>
>> The fourth part of the trilogy.  ;-)
> 
> Thanks.
> 
>> 	* docs/gdb.texinfo: Document record save/restore commands.
> 
> This needs to state the name of the node where you made the changes.

OK

>> +* New commands
>> +
>> +record save <filename> -- Save a 'process record' execution log to a file.
>> +record restore <filename -- Restore an earlier 'process record' session.
> 
> Please format these as we did with other new commands in NEWS.

Well, there's more than one format -- I'll use the most recent.

>> +Save the execution log of the inferior process into a modified core file.
> 
> "Modified" is too overloaded.  Suggest "specially formatted" instead.

OK.

>> +This execution log can then be debugged using the @code{process record}
> 
> Well, you can't really "debug the execution log", can you?  How about
> 
>   You can then replay this execution log as if you recorded it in this
>   @value{GDBN} session.

All right.  See attached.




[-- Attachment #2: docsb.txt --]
[-- Type: text/plain, Size: 2209 bytes --]

2009-10-17  Hui Zhu  <teawater@gmail.com>
	    Michael Snyder  <msnyder@vmware.com>

	* docs/gdb.texinfo (Process Record and Replay): Document 
	record save/restore commands.
	* NEWS: Mention record save/restore commands.

Index: NEWS
===================================================================
RCS file: /cvs/src/src/gdb/NEWS,v
retrieving revision 1.334
diff -u -p -r1.334 NEWS
--- NEWS	15 Oct 2009 19:28:52 -0000	1.334
+++ NEWS	17 Oct 2009 22:24:59 -0000
@@ -11,6 +11,13 @@ Xilinx MicroBlaze		microblaze-*-*
 
 Xilinx MicroBlaze		microblaze
 
+* New commands
+
+record save (filename)
+  Save a 'process record' execution log to a file.
+record restore (filename)
+  Restore an earlier 'process record' session.
+
 *** Changes in GDB 7.0
 
 * GDB now has an interface for JIT compilation.  Applications that
Index: doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.633
diff -u -p -r1.633 gdb.texinfo
--- doc/gdb.texinfo	12 Oct 2009 01:59:54 -0000	1.633
+++ doc/gdb.texinfo	17 Oct 2009 22:24:59 -0000
@@ -5348,6 +5348,26 @@ When record target runs in replay mode (
 subsequent execution log and begin to record a new execution log starting
 from the current address.  This means you will abandon the previously
 recorded ``future'' and begin recording a new ``future''.
+
+@kindex record save
+@kindex rec save
+@item record save [@var{file}]
+@itemx rec save [@var{file}]
+Save the execution log of the inferior process into a modified core file.
+The optional argument @var{file} specifies the file name in which to
+save the execution log.  If not specified, the file name defaults
+to @file{gdb_record.@var{pid}}, where @var{pid} is is the PID of the
+inferior process.
+
+@kindex record restore
+@kindex rec restore
+@item record restore [@var{file}]
+@itemx rec restore [@var{file}]
+Restore the execution log of an earlier session from the file @var{file}
+(required), which has been created using the command @code{record save}.
+This execution log can then be debugged using the @code{process record}
+target, in replay mode, just like replaying a live debugging session.
+
 @end table
 
 

Re: [RFA, 4 of 3] save/restore process record, part 4 (docs and news)

[Eli Zaretskii]

> Date: Sat, 17 Oct 2009 15:19:56 -0700
> From: Michael Snyder <msnyder@vmware.com>
> 
> +* New commands
> +
> +record save (filename)
> +  Save a 'process record' execution log to a file.
> +record restore (filename)
> +  Restore an earlier 'process record' session.
> +

This is okay.

> +@kindex record save
> +@kindex rec save
> +@item record save [@var{file}]
> +@itemx rec save [@var{file}]
> +Save the execution log of the inferior process into a modified core file.
> +The optional argument @var{file} specifies the file name in which to
> +save the execution log.  If not specified, the file name defaults
> +to @file{gdb_record.@var{pid}}, where @var{pid} is is the PID of the
> +inferior process.
> +
> +@kindex record restore
> +@kindex rec restore
> +@item record restore [@var{file}]
> +@itemx rec restore [@var{file}]
> +Restore the execution log of an earlier session from the file @var{file}
> +(required), which has been created using the command @code{record save}.
> +This execution log can then be debugged using the @code{process record}
> +target, in replay mode, just like replaying a live debugging session.

Looks like you sent a wrong patch, since this is unchanged from the
original version.

Re: [RFA, 4 of 3] save/restore process record, part 4 (docs and news)

[Michael Snyder]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

Eli Zaretskii wrote:
> 
> Looks like you sent a wrong patch, since this is unchanged from the
> original version.

Hmmm?  Oh, darn, I see what I did wrong.
Third time's the charm...   ;-)




[-- Attachment #2: docs.txt --]
[-- Type: text/plain, Size: 2169 bytes --]

2009-10-17  Hui Zhu  <teawater@gmail.com>
	    Michael Snyder  <msnyder@vmware.com>

	* NEWS: Mention record save/restore commands.
	* docs/gdb.texinfo (Process Record and Replay): Document 
	record save/restore commands.

Index: NEWS
===================================================================
RCS file: /cvs/src/src/gdb/NEWS,v
retrieving revision 1.334
diff -u -p -r1.334 NEWS
--- NEWS	15 Oct 2009 19:28:52 -0000	1.334
+++ NEWS	18 Oct 2009 04:12:12 -0000
@@ -11,6 +11,13 @@ Xilinx MicroBlaze		microblaze-*-*
 
 Xilinx MicroBlaze		microblaze
 
+* New commands
+
+record save (filename)
+  Save a 'process record' execution log to a file.
+record restore (filename)
+  Restore an earlier 'process record' session.
+
 *** Changes in GDB 7.0
 
 * GDB now has an interface for JIT compilation.  Applications that
Index: doc/gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.633
diff -u -p -r1.633 gdb.texinfo
--- doc/gdb.texinfo	12 Oct 2009 01:59:54 -0000	1.633
+++ doc/gdb.texinfo	18 Oct 2009 04:12:12 -0000
@@ -5348,6 +5348,26 @@ When record target runs in replay mode (
 subsequent execution log and begin to record a new execution log starting
 from the current address.  This means you will abandon the previously
 recorded ``future'' and begin recording a new ``future''.
+
+@kindex record save
+@kindex rec save
+@item record save [@var{file}]
+@itemx rec save [@var{file}]
+Save the execution log of the inferior process into a specially formatted core file.
+The optional argument @var{file} specifies the file name in which to
+save the execution log.  If not specified, the file name defaults
+to @file{gdb_record.@var{pid}}, where @var{pid} is is the PID of the
+inferior process.
+
+@kindex record restore
+@kindex rec restore
+@item record restore [@var{file}]
+@itemx rec restore [@var{file}]
+Restore the execution log of an earlier session from the file @var{file}
+(required), which has been created using the command @code{record save}.
+You can then replay this execution log as if you recorded it in this
+@value{GDBN} session.
+
 @end table
 
 

Re: [RFA, 4 of 3] save/restore process record, part 4 (docs and news)

[Eli Zaretskii]

> Date: Sat, 17 Oct 2009 21:07:38 -0700
> From: Michael Snyder <msnyder@vmware.com>
> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, 
>  "teawater@gmail.com" <teawater@gmail.com>
> 
> Eli Zaretskii wrote:
> > 
> > Looks like you sent a wrong patch, since this is unchanged from the
> > original version.
> 
> Hmmm?  Oh, darn, I see what I did wrong.
> Third time's the charm...   ;-)

Yes, this one is.

Re: [RFA, 4 of 3] save/restore process record, part 4 (docs and news)

[Michael Snyder]

Eli Zaretskii wrote:
>> Date: Sat, 17 Oct 2009 21:07:38 -0700
>> From: Michael Snyder <msnyder@vmware.com>
>> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, 
>>  "teawater@gmail.com" <teawater@gmail.com>
>>
>> Eli Zaretskii wrote:
>>> Looks like you sent a wrong patch, since this is unchanged from the
>>> original version.
>> Hmmm?  Oh, darn, I see what I did wrong.
>> Third time's the charm...   ;-)
> 
> Yes, this one is.
> 
Committed.