From: Alan Hayward <Alan.Hayward@arm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH] Better make rules for IPA objects
Date: Tue, 14 Nov 2017 09:53:00 -0000 [thread overview]
Message-ID: <4AD56343-F7AD-488E-8738-772FEB032116@arm.com> (raw)
In-Reply-To: <9FD839CC-67AD-43A8-B28F-11F78BB6BC94@arm.com>
Ping.
> On 7 Nov 2017, at 10:18, Alan Hayward <Alan.Hayward@arm.com> wrote:
>
> This patch strengthens the rule for compiling arch/ and common/ files
> into IPA.
>
> In the existing code, "foo-ipa.o" will try to match:
> foo-generated.c
> foo-ipa.c
> gdbserver/foo.c
> common/foo.c
> arch/foo.c
>
> If this potentially matched multiple files, then the first is matched.
>
> This patch changes the IPA rules so that files in arch/ and common/ are
> explicitly listed using the directory name.
>
> A future patch could be added to remove the ambiguity from the first three
> matches. I'm not planning on making that change.
>
> This changed is required as part of moving aarch64 to use flexible target
> descriptors.
>
> Alan.
>
> 2017-11-07 Alan Hayward <alan.hayward@arm.com>
>
> gdbserver:
> * Makefile.in: Update arch and common rules.
> * configure.srv: Explicitly mark arch/ and common/ files.
>
> diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in
> index 8e73563b103f720ddd5e77607c3190a2959903f5..1bd4cf93cce192f060c362665fd5df9f4c323f24 100644
> --- a/gdb/gdbserver/Makefile.in
> +++ b/gdb/gdbserver/Makefile.in
> @@ -563,11 +563,11 @@ arch/%.o: ../arch/%.c
> $(IPAGENT_COMPILE) $<
> $(POSTCOMPILE)
>
> -%-ipa.o: ../common/%.c
> +common/%-ipa.o: ../common/%.c
> $(IPAGENT_COMPILE) $<
> $(POSTCOMPILE)
>
> -%-ipa.o: ../arch/%.c
> +arch/%-ipa.o: ../arch/%.c
> $(IPAGENT_COMPILE) $<
> $(POSTCOMPILE)
>
> diff --git a/gdb/gdbserver/configure.srv b/gdb/gdbserver/configure.srv
> index 515c6dc8b3e57574286149ebdca37da149218a35..82c3dc237c3fb6baeb2a72cd9ed66d8c7556d72a 100644
> --- a/gdb/gdbserver/configure.srv
> +++ b/gdb/gdbserver/configure.srv
> @@ -133,7 +133,7 @@ case "${target}" in
> srv_linux_thread_db=yes
> srv_linux_btrace=yes
> ipa_obj="linux-i386-ipa.o linux-x86-tdesc-ipa.o"
> - ipa_obj="${ipa_obj} i386-ipa.o"
> + ipa_obj="${ipa_obj} arch/i386-ipa.o"
> ;;
> i[34567]86-*-lynxos*) srv_regobj=""
> srv_tgtobj="lynx-low.o lynx-i386-low.o fork-child.o fork-inferior.o"
> @@ -383,7 +383,7 @@ case "${target}" in
> srv_linux_thread_db=yes
> srv_linux_btrace=yes
> ipa_obj="linux-amd64-ipa.o linux-x86-tdesc-ipa.o"
> - ipa_obj="${ipa_obj} amd64-ipa.o"
> + ipa_obj="${ipa_obj} arch/amd64-ipa.o"
> ;;
> x86_64-*-mingw*) srv_regobj=""
> srv_tgtobj="x86-low.o x86-dregs.o i387-fp.o win32-low.o win32-i386-low.o”
>
>
next prev parent reply other threads:[~2017-11-14 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 10:41 Alan Hayward
2017-11-14 9:53 ` Alan Hayward [this message]
[not found] ` <86lgj9t8mi.fsf@gmail.com>
2017-11-14 14:18 ` Alan Hayward
2017-11-15 9:17 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD56343-F7AD-488E-8738-772FEB032116@arm.com \
--to=alan.hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox