From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76679 invoked by alias); 14 Nov 2017 09:53:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76660 invoked by uid 89); 14 Nov 2017 09:53:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0053.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Nov 2017 09:53:29 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.218.12; Tue, 14 Nov 2017 09:53:26 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::2891:52f2:59:8e54]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::2891:52f2:59:8e54%16]) with mapi id 15.20.0218.015; Tue, 14 Nov 2017 09:53:26 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd Subject: Re: [PATCH] Better make rules for IPA objects Date: Tue, 14 Nov 2017 09:53:00 -0000 Message-ID: <4AD56343-F7AD-488E-8738-772FEB032116@arm.com> References: <9FD839CC-67AD-43A8-B28F-11F78BB6BC94@arm.com> In-Reply-To: <9FD839CC-67AD-43A8-B28F-11F78BB6BC94@arm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0101;6:8sQqMFCvMg5D9qpBtAWnXGeC5YX393jMpcmAs+KG4H5e3a+ztAUDG5sjEGqkUimc1YIxiACJGei+V+Y8oNg+XQGVGCkAmMngWD6kLCm885RofijP2UPTMycMLeiKTRhjkiHD3fhKRbnZMhLJPS8bZgI6Q2mAnqLFbgeO/zElqP94lrLT++SUQ10oNbmRFr22m4XqoivWsBgdkmNvz/oxbYXXrseTxqThuFl0bysLSvykvcooOvKQA5NtRTr83C2E5l4OQwut749U607K7tr1xKU2NgvLEDaGbLL5yxK+S2PbMnT17HiO/OYKv/mKrbb2W7jhRdYVfBHiPaooqdqKZTY50OgXlI9gibvOq0PHlDI=;5:VgACZX2sf4DfFEwnw+FLeKGNVIk+0FwxBO9OaIZCJV90gUQ+pfm5HyOgqS7SNJxQuPWcZB6Ozo1JDyHeSxLJ1i+2Kk4hDUJhT6mRuTMF2W4uDGFamoAo16M3Hk+SN/0R/xxCaNGJv0+CT1SlRCXV1pxPMgNOg6BFJnYUnmP9N7c=;24:5UaLxXNFW5WsyV8jJDxX12KRN2ImNuFQCcSOmjv114EiGVwDuOYtUqQ9Y/tHklQsE+QoKbY4XnsX2pS5jsEMi2sRMX2XY/JEZ6Ku6fUikfQ=;7:b52y/DNC2Q2k/rVfO2jJKjC4opCx8DO77WhHfpePdkZVnTXB7vD24j1ZWQBdbrsZhmYezgaKm2ceuxYPlicPkflbYk7La8oZYTk2s2p1a8jmnYzednkTToJzHoUggQmjHS+HpxAG8V3rAWluYIKA33KhGFcp3RUmQY0UfFtLCAgldClX8N91w09AugrbD18QIBerSWfPS/5cVCHdfcEsMWdkhMTJSLSZHO5Ux/QWMrVgHz8q36pAG1OkLdh5M941 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 919c00da-6936-414a-0630-08d52b458d19 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603258);SRVR:AM3PR08MB0101; x-ms-traffictypediagnostic: AM3PR08MB0101: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3231022)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR08MB0101;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR08MB0101; x-forefront-prvs: 04916EA04C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(39860400002)(346002)(24454002)(377424004)(189002)(199003)(2501003)(6512007)(5250100002)(53936002)(6246003)(66066001)(99286004)(3280700002)(8936002)(2906002)(14454004)(86362001)(97736004)(4326008)(229853002)(83716003)(6506006)(5640700003)(189998001)(6486002)(6436002)(2900100001)(53546010)(36756003)(6916009)(2950100002)(101416001)(76176999)(50986999)(68736007)(25786009)(54356999)(5660300001)(106356001)(478600001)(72206003)(82746002)(102836003)(33656002)(105586002)(2351001)(3846002)(316002)(6116002)(81156014)(7736002)(81166006)(3660700001)(305945005)(8676002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0101;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <55DF22859CEDF44287496A5335E7C1F8@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 919c00da-6936-414a-0630-08d52b458d19 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2017 09:53:26.0102 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0101 X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00249.txt.bz2 UGluZy4NCg0KPiBPbiA3IE5vdiAyMDE3LCBhdCAxMDoxOCwgQWxhbiBIYXl3 YXJkIDxBbGFuLkhheXdhcmRAYXJtLmNvbT4gd3JvdGU6DQo+IA0KPiBUaGlz IHBhdGNoIHN0cmVuZ3RoZW5zIHRoZSBydWxlIGZvciBjb21waWxpbmcgYXJj aC8gYW5kIGNvbW1vbi8gZmlsZXMNCj4gaW50byBJUEEuDQo+IA0KPiBJbiB0 aGUgZXhpc3RpbmcgY29kZSwgImZvby1pcGEubyIgd2lsbCB0cnkgdG8gbWF0 Y2g6DQo+IGZvby1nZW5lcmF0ZWQuYw0KPiBmb28taXBhLmMNCj4gZ2Ric2Vy dmVyL2Zvby5jDQo+IGNvbW1vbi9mb28uYw0KPiBhcmNoL2Zvby5jDQo+IA0K PiBJZiB0aGlzIHBvdGVudGlhbGx5IG1hdGNoZWQgbXVsdGlwbGUgZmlsZXMs IHRoZW4gdGhlIGZpcnN0IGlzIG1hdGNoZWQuDQo+IA0KPiBUaGlzIHBhdGNo IGNoYW5nZXMgdGhlIElQQSBydWxlcyBzbyB0aGF0IGZpbGVzIGluIGFyY2gv IGFuZCBjb21tb24vIGFyZQ0KPiBleHBsaWNpdGx5IGxpc3RlZCB1c2luZyB0 aGUgZGlyZWN0b3J5IG5hbWUuDQo+IA0KPiBBIGZ1dHVyZSBwYXRjaCBjb3Vs ZCBiZSBhZGRlZCB0byByZW1vdmUgdGhlIGFtYmlndWl0eSBmcm9tIHRoZSBm aXJzdCB0aHJlZQ0KPiBtYXRjaGVzLiBJJ20gbm90IHBsYW5uaW5nIG9uIG1h a2luZyB0aGF0IGNoYW5nZS4NCj4gDQo+IFRoaXMgY2hhbmdlZCBpcyByZXF1 aXJlZCBhcyBwYXJ0IG9mIG1vdmluZyBhYXJjaDY0IHRvIHVzZSBmbGV4aWJs ZSB0YXJnZXQNCj4gZGVzY3JpcHRvcnMuDQo+IA0KPiBBbGFuLg0KPiANCj4g MjAxNy0xMS0wNyAgQWxhbiBIYXl3YXJkICA8YWxhbi5oYXl3YXJkQGFybS5j b20+DQo+IA0KPiBnZGJzZXJ2ZXI6DQo+IAkqIE1ha2VmaWxlLmluOiBVcGRh dGUgYXJjaCBhbmQgY29tbW9uIHJ1bGVzLg0KPiAJKiBjb25maWd1cmUuc3J2 OiBFeHBsaWNpdGx5IG1hcmsgYXJjaC8gYW5kIGNvbW1vbi8gZmlsZXMuDQo+ IA0KPiBkaWZmIC0tZ2l0IGEvZ2RiL2dkYnNlcnZlci9NYWtlZmlsZS5pbiBi L2dkYi9nZGJzZXJ2ZXIvTWFrZWZpbGUuaW4NCj4gaW5kZXggOGU3MzU2M2Ix MDNmNzIwZGRkNWU3NzYwN2MzMTkwYTI5NTk5MDNmNS4uMWJkNGNmOTNjY2Ux OTJmMDYwYzM2MjY2NWZkNWRmOWY0YzMyM2YyNCAxMDA2NDQNCj4gLS0tIGEv Z2RiL2dkYnNlcnZlci9NYWtlZmlsZS5pbg0KPiArKysgYi9nZGIvZ2Ric2Vy dmVyL01ha2VmaWxlLmluDQo+IEBAIC01NjMsMTEgKzU2MywxMSBAQCBhcmNo LyUubzogLi4vYXJjaC8lLmMNCj4gCSQoSVBBR0VOVF9DT01QSUxFKSAkPA0K PiAJJChQT1NUQ09NUElMRSkNCj4gDQo+IC0lLWlwYS5vOiAuLi9jb21tb24v JS5jDQo+ICtjb21tb24vJS1pcGEubzogLi4vY29tbW9uLyUuYw0KPiAJJChJ UEFHRU5UX0NPTVBJTEUpICQ8DQo+IAkkKFBPU1RDT01QSUxFKQ0KPiANCj4g LSUtaXBhLm86IC4uL2FyY2gvJS5jDQo+ICthcmNoLyUtaXBhLm86IC4uL2Fy Y2gvJS5jDQo+IAkkKElQQUdFTlRfQ09NUElMRSkgJDwNCj4gCSQoUE9TVENP TVBJTEUpDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZ2RiL2dkYnNlcnZlci9jb25m aWd1cmUuc3J2IGIvZ2RiL2dkYnNlcnZlci9jb25maWd1cmUuc3J2DQo+IGlu ZGV4IDUxNWM2ZGM4YjNlNTc1NzQyODYxNDllYmRjYTM3ZGExNDkyMThhMzUu LjgyYzNkYzIzN2MzZmI2YmFlYjJhNzJjZDllZDY2ZDhjNzU1NmQ3MmEgMTAw NjQ0DQo+IC0tLSBhL2dkYi9nZGJzZXJ2ZXIvY29uZmlndXJlLnNydg0KPiAr KysgYi9nZGIvZ2Ric2VydmVyL2NvbmZpZ3VyZS5zcnYNCj4gQEAgLTEzMyw3 ICsxMzMsNyBAQCBjYXNlICIke3RhcmdldH0iIGluDQo+IAkJCXNydl9saW51 eF90aHJlYWRfZGI9eWVzDQo+IAkJCXNydl9saW51eF9idHJhY2U9eWVzDQo+ IAkJCWlwYV9vYmo9ImxpbnV4LWkzODYtaXBhLm8gbGludXgteDg2LXRkZXNj LWlwYS5vIg0KPiAtCQkJaXBhX29iaj0iJHtpcGFfb2JqfSBpMzg2LWlwYS5v Ig0KPiArCQkJaXBhX29iaj0iJHtpcGFfb2JqfSBhcmNoL2kzODYtaXBhLm8i DQo+IAkJCTs7DQo+ICBpWzM0NTY3XTg2LSotbHlueG9zKikJc3J2X3JlZ29i aj0iIg0KPiAJCQlzcnZfdGd0b2JqPSJseW54LWxvdy5vIGx5bngtaTM4Ni1s b3cubyBmb3JrLWNoaWxkLm8gZm9yay1pbmZlcmlvci5vIg0KPiBAQCAtMzgz LDcgKzM4Myw3IEBAIGNhc2UgIiR7dGFyZ2V0fSIgaW4NCj4gCQkJc3J2X2xp bnV4X3RocmVhZF9kYj15ZXMNCj4gCQkJc3J2X2xpbnV4X2J0cmFjZT15ZXMN Cj4gCQkJaXBhX29iaj0ibGludXgtYW1kNjQtaXBhLm8gbGludXgteDg2LXRk ZXNjLWlwYS5vIg0KPiAtCQkJaXBhX29iaj0iJHtpcGFfb2JqfSBhbWQ2NC1p cGEubyINCj4gKwkJCWlwYV9vYmo9IiR7aXBhX29ian0gYXJjaC9hbWQ2NC1p cGEubyINCj4gCQkJOzsNCj4gIHg4Nl82NC0qLW1pbmd3KikJc3J2X3JlZ29i aj0iIg0KPiAJCQlzcnZfdGd0b2JqPSJ4ODYtbG93Lm8geDg2LWRyZWdzLm8g aTM4Ny1mcC5vIHdpbjMyLWxvdy5vIHdpbjMyLWkzODYtbG93Lm/igJ0NCj4g DQo+IA0KDQo= >From gdb-patches-return-143378-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Nov 14 11:14:38 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 45570 invoked by alias); 14 Nov 2017 11:14:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 45550 invoked by uid 89); 14 Nov 2017 11:14:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-spam-relays-external:74.125.82.67, H*RU:74.125.82.67, workflow, Hx-languages-length:2118 X-HELO: mail-wm0-f67.google.com Received: from mail-wm0-f67.google.com (HELO mail-wm0-f67.google.com) (74.125.82.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Nov 2017 11:14:36 +0000 Received: by mail-wm0-f67.google.com with SMTP id g141so21068695wmg.2 for ; Tue, 14 Nov 2017 03:14:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=ciiqah8Cpb5uaYix5rb/qeyWLegLGBGTuaklT8yOydc=; b=TR5fPu80PRf5hhpqjUC5RWAjmUiORkoEyjd2LX7fNIigZBwtYiByh+wlQlmlsl+bMz ZflJDrw2C497k+WgOgdws4WrvYM7PmBStv68ApMK9kaHxXEQ+2lk3WUvwVQMVbbGL7s2 wKDIa7UmcJQRuIKnami6FvWD2qrdcxi8ZJYwHjK1fkRZVsv0vJcXB6olaWpVvRxQPEWi JbHhQsOHvroDnJjeRoBuFYAm+KS4VuPAmQoJ/oDuePU1motJVxhxAEXE/9QxJQnwjHJt Df2P8rQmVEKXrjZIlGEcxZe+R/sa3ZJjz/nLLuRT9hNy/GEExmrotOnhyGvjMGHIH0pW EdXA== X-Gm-Message-State: AJaThX4rMzoURw/VACy4qhULtTOSKMxGCDCSjTBVhPH8nK5+G/LDUP1N 9UO8qBBlRpxdPHC8Q8PG1pNXig== X-Google-Smtp-Source: AGs4zMaGTpbPS/YUNNU7A5z2zEKSTvrF9ycsbsp3yGu14AR1aKkOG5Yr9IzFb965BomM83afpxIgCg== X-Received: by 10.28.16.149 with SMTP id 143mr9272093wmq.62.1510658074632; Tue, 14 Nov 2017 03:14:34 -0800 (PST) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id i4sm40056454wra.40.2017.11.14.03.14.33 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 14 Nov 2017 03:14:33 -0800 (PST) From: Yao Qi To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH] Better make rules for IPA objects References: <9FD839CC-67AD-43A8-B28F-11F78BB6BC94@arm.com> Date: Tue, 14 Nov 2017 11:14:00 -0000 In-Reply-To: <9FD839CC-67AD-43A8-B28F-11F78BB6BC94@arm.com> (Alan Hayward's message of "Tue, 7 Nov 2017 10:40:52 +0000") Message-ID: <86lgj9t8mi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00250.txt.bz2 Content-length: 2133 Alan Hayward writes: > -%-ipa.o: ../common/%.c > +common/%-ipa.o: ../common/%.c > $(IPAGENT_COMPILE) $< > $(POSTCOMPILE) We don't have common/ directory in GDBserver build tree, so common/%-ipa.o is useless. Secondly, this "%-ipa.o: ../common/%.c" is removed, common/*.c files can't be built for IPA. Please remove this change. With your patch applied, fail to build libinproctrace.so on x86_64-linux. g++ -std=3Dgnu++11 -shared -fPIC -Wl,--soname=3Dlibinproctrace.so -Wl,--no-= undefined -g -O2 -I. -I../../../binutils-gdb/gdb/gdbserver -I../../../bi= nutils-gdb/gdb/gdbserver/../common -I../../../binutils-gdb/gdb/gdbserver/..= /regformats -I../../../binutils-gdb/gdb/gdbserver/.. -I../../../binutils-gd= b/gdb/gdbserver/../../include -I../../../binutils-gdb/gdb/gdbserver/../gnul= ib/import -Ibuild-gnulib-gdbserver/import -Wall -Wpointer-arith -Wno-unuse= d -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty= -body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compar= e -Wno-narrowing -Wno-error=3Dmaybe-uninitialized -Wformat-nonliteral -Werr= or -DGDBSERVER \ -static-libstdc++ -static-libgcc -Wl,--dynamic-list=3D../../../binutils-gd= b/gdb/gdbserver/proc-service.list -o libinproctrace.so ax-ipa.o common-util= s-ipa.o errors-ipa.o format-ipa.o print-utils-ipa.o regcache-ipa.o remote-u= tils-ipa.o rsp-low-ipa.o tdesc-ipa.o tracepoint-ipa.o utils-ipa.o vec-ipa.o= linux-amd64-ipa.o linux-x86-tdesc-ipa.o arch/amd64-ipa.o -ldl -pthread g++: error: common-utils-ipa.o: No such file or directory g++: error: errors-ipa.o: No such file or directory g++: error: format-ipa.o: No such file or directory g++: error: print-utils-ipa.o: No such file or directory g++: error: rsp-low-ipa.o: No such file or directory g++: error: vec-ipa.o: No such file or directory Makefile:412: recipe for target 'libinproctrace.so' failed This and (https://sourceware.org/ml/gdb-patches/2017-10/msg00888.html) worry me more. You miss something important in the development workflow to make sure your patches posted are well-tested. --=20 Yao (=E9=BD=90=E5=B0=A7)