From: "Sébastien Granjoux" <seb.sfo@free.fr>
To: Joel Brobecker <brobecker@adacore.com>,
Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Fix breakpoints when several source files have the same name
Date: Wed, 30 Sep 2009 18:53:00 -0000 [thread overview]
Message-ID: <4AC3A927.1060702@free.fr> (raw)
In-Reply-To: <20090929222024.GH6362@adacore.com>
Hi Joel,
Joel Brobecker a écrit :
> Really really sorry for taking so long before reviewing this patch.
> Please don't hesitate to send pings on the list to remind us of a patch
> that is sitting unreviewed for more than a week or two.
Ok, I haven't been very pushy on this patch neither but I'm really glad
to make some progress on it as it is still a problem with no real work
around.
> How about changing the patch to only do the fullname matching iff
> (if and only iff) the simple filename matches first. In other words,
> compute the symtab/psymtab fullname only if the filename matches.
That's fine for me but months ago I get an email offlist from Jan
Kratochvil who has fixed this bug with another patch.
I think his patch is better than mine. Instead of adding another
particular case, he has rewritten some functions and add a test case.
The drawback is that it is more difficult to be sure that there is no
regression and I have understood that Jan wants to work a bit more or it.
Anyway, I would really like to get this bug fixed, so if you think it's
ok, I can update my own patch.
Regards,
Sébastien
next prev parent reply other threads:[~2009-09-30 18:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-24 10:49 Sébastien Granjoux
2009-09-29 22:20 ` Joel Brobecker
2009-09-30 18:53 ` Sébastien Granjoux [this message]
2009-09-30 19:07 ` Jan Kratochvil
2009-10-01 21:05 Sébastien Granjoux
2009-10-01 21:45 ` Joel Brobecker
2009-10-02 20:28 ` Sébastien Granjoux
2009-10-29 21:55 Sébastien Granjoux
2009-11-09 20:31 Sébastien Granjoux
2009-11-09 21:09 ` Joel Brobecker
2009-11-09 21:38 ` Sébastien Granjoux
2009-11-09 22:05 ` Joel Brobecker
2009-11-10 18:46 ` Sébastien Granjoux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC3A927.1060702@free.fr \
--to=seb.sfo@free.fr \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox