From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10600 invoked by alias); 30 Sep 2009 18:53:45 -0000 Received: (qmail 10591 invoked by uid 22791); 30 Sep 2009 18:53:44 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp1-g21.free.fr (HELO smtp1-g21.free.fr) (212.27.42.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Sep 2009 18:53:36 +0000 Received: from smtp1-g21.free.fr (localhost [127.0.0.1]) by smtp1-g21.free.fr (Postfix) with ESMTP id 0C85694013D; Wed, 30 Sep 2009 20:53:28 +0200 (CEST) Received: from [192.168.0.11] (cvl92-3-82-247-217-100.fbx.proxad.net [82.247.217.100]) by smtp1-g21.free.fr (Postfix) with ESMTP id 15D2D940041; Wed, 30 Sep 2009 20:53:25 +0200 (CEST) Message-ID: <4AC3A927.1060702@free.fr> Date: Wed, 30 Sep 2009 18:53:00 -0000 From: =?ISO-8859-1?Q?S=E9bastien_Granjoux?= User-Agent: Thunderbird 2.0.0.23 (X11/20090822) MIME-Version: 1.0 To: Joel Brobecker , Jan Kratochvil CC: gdb-patches@sourceware.org Subject: Re: Fix breakpoints when several source files have the same name References: <4A1926A2.1000806@free.fr> <20090929222024.GH6362@adacore.com> In-Reply-To: <20090929222024.GH6362@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00959.txt.bz2 Hi Joel, Joel Brobecker a écrit : > Really really sorry for taking so long before reviewing this patch. > Please don't hesitate to send pings on the list to remind us of a patch > that is sitting unreviewed for more than a week or two. Ok, I haven't been very pushy on this patch neither but I'm really glad to make some progress on it as it is still a problem with no real work around. > How about changing the patch to only do the fullname matching iff > (if and only iff) the simple filename matches first. In other words, > compute the symtab/psymtab fullname only if the filename matches. That's fine for me but months ago I get an email offlist from Jan Kratochvil who has fixed this bug with another patch. I think his patch is better than mine. Instead of adding another particular case, he has rewritten some functions and add a test case. The drawback is that it is more difficult to be sure that there is no regression and I have understood that Jan wants to work a bit more or it. Anyway, I would really like to get this bug fixed, so if you think it's ok, I can update my own patch. Regards, Sébastien